-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape moves focus to editor region when in select mode #62196
Merged
Merged
Commits on Jun 26, 2024
-
Escape moves focus to parent when in select mode
An escape keypress previously toggled the state between editing and select mode. This returns the behavior to the previous implemenetation of Escape clearing block focus... eventually. Now escape will select the parent element all the way up until there are no more, at which point it clears block focus and focuses the body iframe (showing blue outline).
Configuration menu - View commit details
-
Copy full SHA for c191d4d - Browse repository at this point
Copy the full SHA c191d4dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5b69791 - Browse repository at this point
Copy the full SHA 5b69791View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b7d2de - Browse repository at this point
Copy the full SHA 3b7d2deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56b8f86 - Browse repository at this point
Copy the full SHA 56b8f86View commit details -
Redo CSS for editor canvas outline.
- moves selected-block-outline to base styles css so it can be used anywhere - renames the mixin to match mixin naming convention - moves editor canvas outline to block-canvas styles because it needs to work for both iframed and non-iframed versions of the editor - restyle to make canvas focus work for both iframe and non-iframed versions
Configuration menu - View commit details
-
Copy full SHA for c7f7ed3 - Browse repository at this point
Copy the full SHA c7f7ed3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0614c6f - Browse repository at this point
Copy the full SHA 0614c6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 34aa86a - Browse repository at this point
Copy the full SHA 34aa86aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7f3e381 - Browse repository at this point
Copy the full SHA 7f3e381View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd7c1a1 - Browse repository at this point
Copy the full SHA dd7c1a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9712646 - Browse repository at this point
Copy the full SHA 9712646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 474be49 - Browse repository at this point
Copy the full SHA 474be49View commit details -
Configuration menu - View commit details
-
Copy full SHA for c42153e - Browse repository at this point
Copy the full SHA c42153eView commit details -
Revert focus style for regions and add new focus-visible style to han…
…dle sending focus from canvas
Configuration menu - View commit details
-
Copy full SHA for ba6e245 - Browse repository at this point
Copy the full SHA ba6e245View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba2d1ad - Browse repository at this point
Copy the full SHA ba2d1adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7050e0b - Browse repository at this point
Copy the full SHA 7050e0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e5a6d50 - Browse repository at this point
Copy the full SHA e5a6d50View commit details -
Configuration menu - View commit details
-
Copy full SHA for c245a89 - Browse repository at this point
Copy the full SHA c245a89View commit details -
Configuration menu - View commit details
-
Copy full SHA for 55f0f32 - Browse repository at this point
Copy the full SHA 55f0f32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 801ceb9 - Browse repository at this point
Copy the full SHA 801ceb9View commit details -
Configuration menu - View commit details
-
Copy full SHA for b32c3c8 - Browse repository at this point
Copy the full SHA b32c3c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 387ed23 - Browse repository at this point
Copy the full SHA 387ed23View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.