Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape moves focus to editor region when in select mode #62196

Merged
merged 21 commits into from
Jun 26, 2024

Commits on Jun 26, 2024

  1. Escape moves focus to parent when in select mode

    An escape keypress previously toggled the state between editing and select mode. This returns the behavior to the previous implemenetation of Escape clearing block focus... eventually. Now escape will select the parent element all the way up until there are no more, at which point it clears block focus and focuses the body iframe (showing blue outline).
    jeryj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c191d4d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b69791 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3b7d2de View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    56b8f86 View commit details
    Browse the repository at this point in the history
  5. Redo CSS for editor canvas outline.

    - moves selected-block-outline to base styles css so it can be used anywhere
    - renames the mixin to match mixin naming convention
    - moves editor canvas outline to block-canvas styles because it needs to work for both iframed and non-iframed versions of the editor
    - restyle to make canvas focus work for both iframe and non-iframed versions
    jeryj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c7f7ed3 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0614c6f View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    34aa86a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7f3e381 View commit details
    Browse the repository at this point in the history
  9. Remove body focus styles

    jeryj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    dd7c1a1 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    9712646 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    474be49 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    c42153e View commit details
    Browse the repository at this point in the history
  13. Revert focus style for regions and add new focus-visible style to han…

    …dle sending focus from canvas
    jeryj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    ba6e245 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    ba2d1ad View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    7050e0b View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    e5a6d50 View commit details
    Browse the repository at this point in the history
  17. Update test to right focus area

    jeryj committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c245a89 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    55f0f32 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    801ceb9 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    b32c3c8 View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    387ed23 View commit details
    Browse the repository at this point in the history