Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct capability for the Experiments page #66118

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

rmccue
Copy link
Contributor

@rmccue rmccue commented Oct 15, 2024

What?

Changes the capability for the Experiments page to manage_options

Why?

Fixes #66117

How?

Changes the page registration cap.

Testing Instructions

  1. Create a user as an Editor
  2. Log in as that user
  3. Observe Experiments page before and after

Copy link

github-actions bot commented Oct 15, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rmccue <rmccue@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy swissspidy added the [Type] Bug An existing feature does not function as intended label Oct 15, 2024
@rmccue
Copy link
Contributor Author

rmccue commented Oct 15, 2024

The following contributors have not linked their GitHub and WordPress.org accounts: @rmccue.

Fixed!

@rmccue rmccue added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 15, 2024
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Oct 15, 2024
@rmccue
Copy link
Contributor Author

rmccue commented Oct 15, 2024

I searched beforehand but somehow it didn't show @t-hamano's #56359, so request whoever merges props them as well :)

@swissspidy swissspidy added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Oct 15, 2024
@swissspidy swissspidy merged commit 43417f3 into trunk Oct 15, 2024
74 of 78 checks passed
@swissspidy swissspidy deleted the fix/experiments-capability branch October 15, 2024 11:09
@github-actions github-actions bot added this to the Gutenberg 19.5 milestone Oct 15, 2024
@priethor priethor added the Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts label Oct 23, 2024
@swissspidy swissspidy removed No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Bug An existing feature does not function as intended labels Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Plugin Issues or PRs related to Gutenberg Plugin management related efforts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Experiments Settings page is available to edit_posts, should be manage_options
3 participants