Performance tests : - Fix/compare performance with correct branch #66196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbravobernal
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
added
the
[Type] Automated Testing
youknowriad
reviewed
Oct 17, 2024
youknowriad
removed
[Type] Bug
youknowriad
approved these changes
Oct 17, 2024
youknowriad
added
the
Backport to WP 6.7 Beta/RC
|
Thanks for the fix 🙂 I wasn't sure why the performance tests were failing in manual cherry picks like this one: link. |
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: f98cdf7 |
gutenbergplugin
pushed a commit
that referenced
this pull request
Oct 17, 2024
…6196) * Target base branch instead of just trunk * Update description Co-authored-by: cbravobernal <cbravobernal@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
github-actions
bot
added
the
Backported to WP Core
This was referenced Oct 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Target Performance tests to base branch instead of just Trunk.
Why?
If
trunkdiffers from another base branch, likewp/6.7, changing for example selectors. Performance tests will fail on all cherry picks to releases branches.Testing Instructions
I'll make this PR to 6.7 to see if performance is being executed there.