Comment Title Block: Validate comments count is always an integer #66357
+6
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #66299
What?
Ensure the comments count is always treated as an integer in the
core/comments-title
block rendering function.Why?
The
get_comments_number()
function can return either an integer or a numeric string. This inconsistency can cause issues when checking for zero comments, especially when plugins filter the comment count to an integer. By casting the result to an integer, we ensure consistent behavior and correct condition checks.How?
get_comments_number()
to an integer and update all related condition checks to use integer comparisons.%s
as is instead of converting to%d
to maintain consistency withedit.js
.Testing Instructions
core/comments
block on a post template.Testing Instructions for Keyboard
N/A - This change does not affect the user interface directly.
Screenshots or screencast
N/A