Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

truncate data refresh percent change #808

Closed
wants to merge 3 commits into from

Conversation

prasanna4567
Copy link

@prasanna4567 prasanna4567 commented Oct 18, 2022

Fixes

Fixes WordPress/openverse#1581 by @AetherUnbound

Description

Did some basic string truncation on the data refresh percent to show 3 digits after decimal point.

Testing Instructions

Added relevant test cases

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@prasanna4567 prasanna4567 requested a review from a team as a code owner October 18, 2022 16:52
@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository 🟩 priority: low Low priority and doesn't need to be rushed labels Oct 18, 2022
@prasanna4567
Copy link
Author

Hi @AetherUnbound!
Please review this PR and let me know your inputs.

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this PR @prasanna4567, and for adding the extra tests! We're actually hoping for something a bit more adaptive, here are some specific examples in the original issue:

  • 368.8725687073269 -> 368.873
  • 0.21550955625949816 -> 0.216
  • 0.0001546016462204149 -> 0.000155

Unfortunately, just setting the significant digits to .3f means that the 3rd case will not show any change. Do you think you'd be able to add some logic to the reporting module to truncate the decimal in this manner?

@AetherUnbound
Copy link
Contributor

Hi @prasanna4567, do you still have capacity/availability to make the requested changes to this PR?

@openverse-bot
Copy link
Contributor

Based on the low urgency of this PR, the following reviewers are being gently reminded to review this PR:

@obulat
@stacimc
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was updated 5 day(s) ago. PRs labelled with low urgency are expected to be reviewed within 5 weekday(s)2.

@prasanna4567, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@AetherUnbound
Copy link
Contributor

I'm going to go ahead and close this PR, @prasanna4567 feel free to reopen it if you find you have the time and capacity to do so 🙂

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Truncate data refresh percent change report to 3 digits after the decimal
3 participants