Encode spaces in metropolitan urls

WordPress · Oct 26, 2023 · 203d303 · 203d303
1 parent 57780d7
commit 203d303
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/catalog/dags/providers/provider_api_scripts/metropolitan_museum.py b/catalog/dags/providers/provider_api_scripts/metropolitan_museum.py
@@ -113,8 +113,8 @@ def get_record_data(self, object_id):
 
         return [
             {
-                "foreign_landing_url": foreign_landing_url,
-                "url": img,
+                "foreign_landing_url": foreign_landing_url.replace(" ", "%20"),
+                "url": img.replace(" ", "%20"),
                 "license_info": self.DEFAULT_LICENSE_INFO,
                 "foreign_identifier": self._get_foreign_id(object_id, img),
                 "creator": artist,

diff --git a/...ovider_api_scripts/resources/metropolitan_museum_of_art/sample_additional_image_data.json b/...ovider_api_scripts/resources/metropolitan_museum_of_art/sample_additional_image_data.json
@@ -57,9 +57,9 @@
   },
   {
     "creator": "Kiyohara Yukinobu",
-    "foreign_identifier": "45734-DP251120",
+    "foreign_identifier": "45734-1972",
     "foreign_landing_url": "https://wwwstg.metmuseum.org/art/collection/search/45734",
-    "url": "https://images.metmuseum.org/CRDImages/as/original/DP251120.jpg",
+    "url": "https://images.metmuseum.org/CRDImages/dp/original/1972.173%20RECTO.jpg",
     "license_info": {
       "license": "cc0",
       "url": "https://creativecommons.org/publicdomain/zero/1.0/",

diff --git a/.../providers/provider_api_scripts/resources/metropolitan_museum_of_art/sample_response.json b/.../providers/provider_api_scripts/resources/metropolitan_museum_of_art/sample_response.json
@@ -3,7 +3,7 @@
   "accessionYear": "1936",
   "additionalImages": [
     "https://images.metmuseum.org/CRDImages/as/original/DP251138.jpg",
-    "https://images.metmuseum.org/CRDImages/as/original/DP251120.jpg"
+    "https://images.metmuseum.org/CRDImages/dp/original/1972.173 RECTO.jpg"
   ],
   "artistAlphaSort": "Kiyohara Yukinobu",
   "artistBeginDate": "1643",