Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove just output from CI job #3223

Closed
dhruvkb opened this issue Oct 19, 2023 · 3 comments · Fixed by #3229
Closed

Remove just output from CI job #3223

dhruvkb opened this issue Oct 19, 2023 · 3 comments · Fixed by #3229
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations

Comments

@dhruvkb
Copy link
Member

dhruvkb commented Oct 19, 2023

Description

The CI job runs just without any arguments and prints a beautiful, albeit redundant, list of all available recipes. This should be removed.

Reproduction

See this log.
@dhruvkb dhruvkb added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Oct 19, 2023
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Openverse Backlog Oct 19, 2023
@ngken0995
Copy link
Collaborator

ngken0995 commented Oct 19, 2023 •
edited
Loading

@dhruvkb The install_deps default to true and install_recipes is an empty string. we can remove install_recipes and set install_deps as false. Can I work on this?

@bermr bermr mentioned this issue Oct 19, 2023
Merged
8 tasks
@bermr
Copy link
Contributor

bermr commented Oct 19, 2023

Hi! I created a PR (#3229). Please let me know if the proposed solution is good. Thanks!

@bermr
Copy link
Contributor

bermr commented Oct 19, 2023

Sorry @ngken0995, didn't see your comment. I did something like what you said.

@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Openverse Backlog Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Openverse Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove just executions without arguments from CI bermr/openverse
3 participants
@dhruvkb @bermr @ngken0995