Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove just executions without arguments from CI #3229

Merged
merged 3 commits into from
Oct 21, 2023

Conversation

bermr
Copy link
Contributor

@bermr bermr commented Oct 19, 2023

Fixes #3223

Fixes #3223 by @dhruvkb

Description

Removes just call from some jobs

Testing Instructions

Run the ci

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@bermr bermr requested a review from a team as a code owner October 19, 2023 15:19
@bermr bermr requested review from fcoveram and stacimc October 19, 2023 15:19
@openverse-bot openverse-bot added 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: mgmt Related to repo management and automations labels Oct 19, 2023
@fcoveram fcoveram removed their request for review October 19, 2023 15:49
Copy link
Collaborator

@stacimc stacimc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, verified the unwanted output is now missing from the CI jobs. Adding @dhruvkb as second reviewer.

@stacimc stacimc requested a review from dhruvkb October 20, 2023 18:37
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When install_deps is false, can you also remove the install_recipe param as that no longer has any effect? I can approve the PR after that.

An even better solution would be to not have the install_deps param at all and instead skip the installation step if install_recipe is a blank string. Would you like to do that @bermr? It's okay if you don't want to, the first part is also adequate.

@bermr
Copy link
Contributor Author

bermr commented Oct 21, 2023

Hey @dhruvkb, thanks for replying. Added commits with the changes requested.

Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incredible, thank you so much @bermr! LGTM.

@dhruvkb dhruvkb changed the title ci: removes just executions without arguments from ci Remove just executions without arguments from CI Oct 21, 2023
@dhruvkb dhruvkb merged commit a46a7e4 into WordPress:main Oct 21, 2023
47 checks passed
@bermr
Copy link
Contributor Author

bermr commented Oct 21, 2023

Thank you too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove just output from CI job
4 participants