-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove just
executions without arguments from CI
#3229
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, verified the unwanted output is now missing from the CI jobs. Adding @dhruvkb as second reviewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When install_deps
is false, can you also remove the install_recipe
param as that no longer has any effect? I can approve the PR after that.
An even better solution would be to not have the install_deps
param at all and instead skip the installation step if install_recipe
is a blank string. Would you like to do that @bermr? It's okay if you don't want to, the first part is also adequate.
Hey @dhruvkb, thanks for replying. Added commits with the changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is incredible, thank you so much @bermr! LGTM.
just
executions without arguments from CI
Thank you too! |
Fixes #3223
Fixes #3223 by @dhruvkb
Description
Removes
just
call from some jobsTesting Instructions
Run the ci
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin