-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added robots.txt for API endpoints #3165
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MysteryManav you should also add your previous changes to urls/__init__.py
to this PR.
Also you can update the PR by pushing more commits to the same branch, you don't need to close your existing PR and create a separate PR for each change.
@dhruvkb done, sorry i had to clone the repo again due to some problems on my side, so i forgot to redo the changes, should be fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, except for a minor nit.
@@ -35,6 +35,13 @@ | |||
path("admin/", admin.site.urls), | |||
path("healthcheck/", HealthCheck.as_view(), name="health"), | |||
path("v1/", include(versioned_paths)), | |||
path( | |||
"robots.txt/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know if there should be a trailing slash for a .txt
file. I'm leaning towards no, there shouldn't be one.
"robots.txt/", | |
"robots.txt", |
I'll let the other reviewers chime in on that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok will keep that in mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, @MysteryManav! 🎉
Fixes
Fixes #3060 by @dhruvkb
Description
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin
@dhruvkb @obulat