Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix for undefined in Nuxt provider data #3185

Merged
merged 3 commits into from
Oct 26, 2023
Merged

Hotfix for undefined in Nuxt provider data #3185

merged 3 commits into from
Oct 26, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 11, 2023

Fixes

Fixes #3184 by @sentry-io

Description

This PR logs a warning and returns [] from getProviderStats if the data property in the /stats endpoint returns undefined. This is only a fix for the frontend, and API should implement a fix to never returns undefined from /stats endpoint.

Testing Instructions

The CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner October 11, 2023 10:10
@github-actions github-actions bot added the 🧱 stack: frontend Related to the Nuxt frontend label Oct 11, 2023
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Oct 11, 2023
@github-actions
Copy link

github-actions bot commented Oct 11, 2023 •
edited
Loading

Size Change: +120 B (0%)

Total Size: 938 kB

Filename Size Change
./frontend/.nuxt/dist/client/app.js 123 kB +98 B (0%)
./frontend/.nuxt/dist/client/app.modern.js 115 kB +74 B (0%)
./frontend/.nuxt/dist/client/vendors/app.js 68.2 kB -47 B (0%)
ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/242.js 342 B 0 B
./frontend/.nuxt/dist/client/242.modern.js 346 B 0 B
./frontend/.nuxt/dist/client/243.js 1.85 kB 0 B
./frontend/.nuxt/dist/client/commons/app.js 90 kB -8 B (0%)
./frontend/.nuxt/dist/client/commons/app.modern.js 81 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.js 5.18 kB -1 B (0%)
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/e4094511.modern.js 5.62 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/loading-icon.js 728 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 733 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 515 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 519 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.82 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.64 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.51 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.38 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-control.js 1.51 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-control.modern.js 1.5 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.js 1.12 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 1.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 959 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 961 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 6.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 6.96 kB 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 642 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.35 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.35 kB 0 B
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.3 kB 0 B
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 530 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 534 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 492 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 496 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.33 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.79 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 4 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.34 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 795 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 799 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.48 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.js 5.21 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.58 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.44 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 2 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 1.92 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 1.92 kB 0 B
./frontend/.nuxt/dist/client/components/v-get-media-button.js 622 B 0 B
./frontend/.nuxt/dist/client/components/v-get-media-button.modern.js 627 B 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.js 576 B 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 574 B 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 2.24 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 2.23 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.51 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.38 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 648 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.06 kB -2 B (0%)
./frontend/.nuxt/dist/client/components/v-media-details.js 5.8 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 5.65 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 930 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 940 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 3 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.97 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 831 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 825 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata-value.js 586 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata-value.modern.js 593 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata.js 1.3 kB 0 B
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 1.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 980 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 973 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.01 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 825 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 742 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.51 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.37 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-images.js 803 B 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 721 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 977 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 980 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 1.72 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 618 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 622 B 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.17 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.01 kB -1 B (0%)
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 916 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.js 14.8 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 14.8 kB 0 B
./frontend/.nuxt/dist/client/components/v-tag.js 411 B 0 B
./frontend/.nuxt/dist/client/components/v-tag.modern.js 415 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 306 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 17.4 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 16.4 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.js 15.8 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 14.7 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.js 4.97 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.74 kB 0 B
./frontend/.nuxt/dist/client/pages/index.js 6.38 kB 0 B
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.js 1.47 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.46 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.62 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.61 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 5.79 kB +2 B (0%)
./frontend/.nuxt/dist/client/pages/search.modern.js 8.14 kB +1 B (0%)
./frontend/.nuxt/dist/client/pages/search/audio.js 499 B 0 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 503 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.js 453 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 454 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.js 316 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 320 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 239 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 244 B 0 B
./frontend/.nuxt/dist/client/pages/sensitive-content.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/pages/sensitive-content.modern.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/runtime.js 2.8 kB 0 B
./frontend/.nuxt/dist/client/runtime.modern.js 2.81 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.1 kB +1 B (0%)

compressed-size-action

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🐛 tooling: sentry Sentry issue 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🐛 tooling: sentry Sentry issue labels Oct 11, 2023
dhruvkb
dhruvkb approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good fix!

@obulat obulat force-pushed the fix/undefined-provider-data branch 2 times, most recently from bccf4e8 to b89e0dc Compare October 13, 2023 06:04
@obulat obulat requested a review from krysal October 18, 2023 11:03
krysal
krysal reviewed Oct 20, 2023
View reviewed changes
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this have a unit test to check for the returned data type?

API should implement a fix to never returns undefined from /stats endpoint.

Also, there is no undefined type in Python per see, it sounds strange 🤔

@openverse-bot
Copy link
Collaborator

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@AetherUnbound
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 7 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2.

@obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday. ↩

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

@obulat obulat force-pushed the fix/undefined-provider-data branch from b89e0dc to a1cd360 Compare October 23, 2023 13:00
@krysal krysal marked this pull request as draft October 23, 2023 14:45
@obulat obulat force-pushed the fix/undefined-provider-data branch 2 times, most recently from beaf18d to 503863a Compare October 24, 2023 03:27
@obulat obulat requested a review from krysal October 24, 2023 03:29
@obulat obulat force-pushed the fix/undefined-provider-data branch from 503863a to d8f97ac Compare October 24, 2023 03:30
@obulat obulat marked this pull request as ready for review October 24, 2023 13:52
krysal
krysal approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@obulat obulat merged commit 23d4536 into main Oct 26, 2023
45 checks passed
@obulat obulat deleted the fix/undefined-provider-data branch October 26, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@krysal krysal krysal approved these changes

@AetherUnbound AetherUnbound Awaiting requested review from AetherUnbound AetherUnbound is a code owner automatically assigned from WordPress/openverse-frontend

Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stats endpoint can return undefined in data
4 participants
@obulat @openverse-bot @krysal @dhruvkb