Remove unused thumb tapes #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟨 priority: medium
|
Size Change: 0 B Total Size: 931 kB ℹ️ View Unchanged
|
|
Why are they not used anymore? |
dhruvkb
approved these changes
Oct 11, 2023
sarayourfriend
previously approved these changes
Oct 11, 2023
There was a problem hiding this comment.
Awesome! I wonder if there's any way for us to automatically detect unused tapes 🤔 Apparently talkback is capable of giving that information: https://github.com/ijpiantanida/talkback#exit-summary
I was thinking about this for how to respond to @krysal. I don't know if it's 100% true that these aren't used just because CI passes. It could be that CI passed because the thumbnails were just requested (successfully) as normal? @obulat how did you tell that these weren't being used? Did you use the talkback summary? I wonder if we used |
sarayourfriend
dismissed
their stale review
I want to confirm for sure that we're confident these aren't used.
|
When working on #3186, I deleted all of the thumbnail tapes, and then ran
We decided that we want to use the real images because they would should the image grid with images of different sizes. If we only block the |
AetherUnbound
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
I didn't open an issue for this. While working on #3186, I realized that there are a lot of thumbnail tapes that are not used in tests, and their lack does not affect the CI.
Description
This PR removes the thumb tapes that don't affect the CI.
Testing Instructions
The CI should pass.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin