Allow runtime configuration of nginx listening port #3219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
added
🟨 priority: medium
|
Size Change: 0 B Total Size: 934 kB ℹ️ View Unchanged
|
obulat
requested changes
Oct 18, 2023
There was a problem hiding this comment.
I tried changing the port from 8080 to something else locally, and saw that docker-compose.yaml port needs to change, too:
Line 333 in 90396b2
Can we set the env variable on the parent directory? Or do we need to add documentation saying that the port needs to be updated if the env variable inside frontend/ directory is set to something different than 8080?
We can, but it's just support for testing a feature that shouldn't need to be tested after this. I guess if we want it to be an end-to-end test, we can set the variable in |
I guess we will not change the 8080 locally anyways, so I'm going to approve this PR. I'm not sure if we should add a comment in |
obulat
approved these changes
Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to https://github.com/WordPress/openverse-infrastructure/pull/648
Description
ECS FARGATE requires that container and host ports match on a container definition. In the related PR we tried to map Nuxt to a different host port, in order to allow Nginx to listen on 8443 so that the target group port doesn't need to change. We did that by juggling the host ports, but we can't have different host and container ports. Nuxt lets you override the port by passing
-p, but we need to enable runtime configuration of the Nginx port by using an environment variable.The net change in this PR is that you should be able to pass
OPENVERSE_NGINX_LISTEN_PORTenvironment variable to the container and have Nginx listen on a port other than 8080. Proof that it works is in the fact that it still listens to 8080 now, as that is set as the default for that variable in the container build.Testing Instructions
Run
just build frontend_nginx && just frontend/upand confirm you can still access thefrontend_nginxservice atlocalhost:50290. You also need to run the frontend locally on port8443usingjust frontend/devChecklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin