-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update the Shim README title to be the same as the title of the linked docs page and adding a shim README.md file that redirect to the appropriate service documentation site #3230
Conversation
Shim README files added to the catalog sub folder that point to the documentation site.
Shim README files added to the api subfolders that point to the documentation site.
README file Updated to the `Shim README` file that point to Ingestion Server documentation site.
Shim README file added to the frontend subfolder that point to the documentation site.
Add a shim README that direct to the documentation site
Add shim README file that link to the proper service documentation site
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I re-based this PR onto the wordpress/main
branch for you. It should be fine now, and I'll approve as soon as the CI passes. Thank you for your contribution, @AlajeBash !
For the future, never open a PR from your main
branch: it is really difficult to update your fork after that because the main branches diverge. I've done so, and I know how difficult it is :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You will have to add exclude_patterns
to the Sphinx conf so that the documentation/README.md
does not raise errors about not being included in the toctree.
Fixes
Fixes #3205 by @AetherUnbound
Description
I add shim README files to the required service subfolders that point to the documentation site, by can create a simple README.md file in each of the subfolder of the services with the appropriate links.
Airflow Catalog
Django API
Ingestion server
Nuxt frontend
documentation
Automations
Node.js packages
@openverse/eslint-plugin
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin