-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused utils #3239
Remove unused utils #3239
Conversation
Size Change: 0 B Total Size: 946 kB ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI is passing which gives me a lot of confidence that they were indeed unused.
Based on the low urgency of this PR, the following reviewers are being gently reminded to review this PR: @AetherUnbound Excluding weekend1 days, this PR was ready for review 5 day(s) ago. PRs labelled with low urgency are expected to be reviewed within 5 weekday(s)2. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
5fe4370
to
3766699
Compare
3766699
to
23a3d0c
Compare
Fixes
Quick cleanup PR after #3136
Description
The Nuxt query parameter computation was simplified in #3136, and now all of the query string to query parameter object is done by Vue router.
I noticed that I didn't remove the
util
file that's no longer used, so I removed it. Then, I also audited other files in/utils
directory, and removed other unused files.local
was replaced by VueUseuseLocalStorage
, andprop-validators
are not used anywhere.Testing Instructions
The CI should pass
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin