Skip to content

Update Nuxt sentry dependency #3248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2023
Merged

Update Nuxt sentry dependency #3248

merged 2 commits into from
Nov 2, 2023

Conversation

khushi-kothari
Copy link
Contributor

Fixes

Related to #3242 by @obulat

Description

Update @nuxtjs/sentry dependencies.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@khushi-kothari khushi-kothari requested a review from a team as a code owner October 25, 2023 17:39
@openverse-bot openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Oct 25, 2023
@khushi-kothari khushi-kothari changed the title Nuxt sentry Update Nuxt sentry dependency Oct 25, 2023
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Oct 26, 2023
@obulat obulat marked this pull request as draft October 26, 2023 06:52
@obulat obulat mentioned this pull request Oct 26, 2023
9 tasks
@khushi-kothari khushi-kothari requested a review from obulat October 26, 2023 10:53
@khushi-kothari khushi-kothari marked this pull request as ready for review October 26, 2023 11:04
@obulat
Copy link
Contributor

obulat commented Oct 26, 2023

@khushi-kothari , you'll need to update the lock file as well to make the CI pass.

@obulat obulat marked this pull request as draft October 26, 2023 12:16
@obulat
Copy link
Contributor

obulat commented Oct 26, 2023

@khushi-kothari, what process do you follow to update the lock file? I think it keeps saving the old changes: too many lines are changed in this PR, and it appears that the Vue changes are still in the lock file (judging by the lint warnings about default exports. I think those are caused by one of the Vue or Nuxt updates)

@khushi-kothari
Copy link
Contributor Author

khushi-kothari commented Oct 26, 2023

@khushi-kothari, what process do you follow to update the lock file? I think it keeps saving the old changes: too many lines are changed in this PR, and it appears that the Vue changes are still in the lock file (judging by the lint warnings about default exports. I think those are caused by one of the Vue or Nuxt updates)

Reference to what I think can be causing the issue and what steps I am following.

@obulat obulat marked this pull request as ready for review October 27, 2023 10:56
khushi-kothari and others added 2 commits October 31, 2023 18:17
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat merged commit a14a742 into WordPress:main Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants