-
Notifications
You must be signed in to change notification settings - Fork 221
Update focus-trap dependency #3256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove updates to packages other than focus-trap
, and mark this PR as ready for review, @khushi-kothari .
Ok, this is good to go @obulat! Passing all the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The updated focus trap works fine, and the CI passes 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks @khushi-kothari!
Yes, I'm happy to contribute. Thankyou @dhruvkb to review it 😄 |
Fixes
Related to #3242 by @obulat
Description
Update focus-trap dependency
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin