Implementation of project board automations #3375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
changed the title
openverse-bot
added
🟨 priority: medium
…oject_automations_impl
|
Size Change: 0 B Total Size: 974 kB ℹ️ View Unchanged
|
github-actions
bot
added
the
🧱 stack: documentation
|
Full-stack documentation: https://docs.openverse.org/_preview/3375 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. New files ➕: Changed files 🔄:
|
dhruvkb
force-pushed
the
project_automations_impl
branch
from
e277220 to
4e5a052
Compare
dhruvkb
commented
Nov 22, 2023
Comment on lines
+69
to
+72
| - name: Unzip artifact | ||
| run: | | ||
| unzip event_info.zip | ||
| mv event.json /tmp/event.json |
There was a problem hiding this comment.
This is one thing that's bothering me a lot, it's two lines of Bash breaking up two action/github-scripts. Surely it could be done inside JS? Or the previous step in Bash?
There was a problem hiding this comment.
Could use https://www.npmjs.com/package/unzipper to do the unzipping in JavaScript? Converting the previous github script to bash looks more complicated to me (lots of gh cli response parsing 🫠).
This was referenced Nov 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #3374 by @dhruvkb
Description
This PR implements the changes and additions to the project automations as per the plan outlined in #3042.
Given how GitHub Actions development goes, I'm anticipating quite a few revisions on this work once the actions start running and failing and exposing edge cases so if you could review it a bit deeply, we might catch and patch those cases faster.
Testing Instructions
The changes are so tightly coupled with GitHub that it's very hard to test them at all. Also they need an access token making it not possible to test them in CI. However here are some bits that you can test locally.
Projectexport ACCESS_TOKEN=<your token>.nodeREPL from theautomations/jsdirectory.PullRequestexport ACCESS_TOKEN=<your token>.nodeREPL from theautomations/jsdirectory.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin