Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix loading skeletons #3414

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Fix loading skeletons #3414

merged 1 commit into from
Nov 30, 2023

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 29, 2023

Fixes

Follow up on #3341

Description

The linked PR removed the deprecated usage of this in a prop validator. However, the template wasn't updated, so the grid skeleton does not show up anymore. This PR fixes it, replacing numElemss with elementCount in the template.

Testing Instructions

Run the Nuxt app and search for something. You should see the loading skeletons before the results load. You can use throttling in the browser developer tools if your network is too fast to see the loading skeletons.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin 
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat
Fix loading skeletons
16e6579 
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat requested a review from a team as a code owner November 29, 2023 05:45
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🧱 stack: frontend Related to the Nuxt frontend 🕹 aspect: interface Concerns end-users' experience with the software labels Nov 29, 2023
dhruvkb
dhruvkb approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, nice fix, thanks!

@github-actions GitHub Actions
Copy link

Size Change: +20 B (0%)

Total Size: 1.01 MB

ℹ️ View Unchanged
Filename Size Change
./frontend/.nuxt/dist/client/247.js 343 B 0 B
./frontend/.nuxt/dist/client/247.modern.js 346 B 0 B
./frontend/.nuxt/dist/client/248.js 1.85 kB 0 B
./frontend/.nuxt/dist/client/app.js 132 kB -1 B (0%)
./frontend/.nuxt/dist/client/app.modern.js 123 kB +2 B (0%)
./frontend/.nuxt/dist/client/commons/app.js 105 kB 0 B
./frontend/.nuxt/dist/client/commons/app.modern.js 87.5 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/4e2d09e1.js 5.18 kB 0 B
./frontend/.nuxt/dist/client/commons/components/v-error-section/components/v-external-search-form/components/v-external-source-li/4e2d09e1.modern.js 5.62 kB 0 B
./frontend/.nuxt/dist/client/components/loading-icon.js 731 B 0 B
./frontend/.nuxt/dist/client/components/loading-icon.modern.js 734 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.js 514 B 0 B
./frontend/.nuxt/dist/client/components/table-sort-icon.modern.js 518 B 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.js 6.85 kB 0 B
./frontend/.nuxt/dist/client/components/v-all-results-grid.modern.js 6.68 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-collection.js 4.5 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-collection.modern.js 4.38 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-audio-list.js 1.43 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-list.modern.js 1.41 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.js 1.12 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-result.modern.js 1.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.js 957 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track-skeleton.modern.js 960 B 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.js 5.15 kB 0 B
./frontend/.nuxt/dist/client/components/v-audio-track.modern.js 5.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-back-to-search-results-link.modern.js 639 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.js 632 B 0 B
./frontend/.nuxt/dist/client/components/v-bone.modern.js 636 B 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.js 1.16 kB 0 B
./frontend/.nuxt/dist/client/components/v-box-layout.modern.js 1.16 kB 0 B
./frontend/.nuxt/dist/client/components/v-by-line.js 2.34 kB 0 B
./frontend/.nuxt/dist/client/components/v-by-line.modern.js 2.32 kB 0 B
./frontend/.nuxt/dist/client/components/v-collection-header.js 1.49 kB 0 B
./frontend/.nuxt/dist/client/components/v-collection-header.modern.js 1.5 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-link.modern.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-page.js 531 B 0 B
./frontend/.nuxt/dist/client/components/v-content-page.modern.js 536 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.js 493 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-button.modern.js 497 B 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.js 3.35 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-form.modern.js 3.23 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.js 3.82 kB 0 B
./frontend/.nuxt/dist/client/components/v-content-report-popover.modern.js 3.69 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.js 3.8 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-button.modern.js 3.81 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.js 2.34 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license.modern.js 2.31 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-license-tab-panel/components/v-media-reuse/pages/image/_id/index.js 3.8 kB 0 B
./frontend/.nuxt/dist/client/components/v-copy-license/components/v-license-tab-panel/components/v-media-reuse/pages/image/_id/index.modern.js 3.81 kB 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.js 795 B 0 B
./frontend/.nuxt/dist/client/components/v-dmca-notice.modern.js 801 B 0 B
./frontend/.nuxt/dist/client/components/v-error-image.js 2.51 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-image.modern.js 2.47 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.js 5.22 kB 0 B
./frontend/.nuxt/dist/client/components/v-error-section.modern.js 4.58 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.js 4.1 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-search-form.modern.js 3.44 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.js 2.63 kB 0 B
./frontend/.nuxt/dist/client/components/v-external-source-list.modern.js 1.99 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.js 3.76 kB 0 B
./frontend/.nuxt/dist/client/components/v-full-layout.modern.js 3.74 kB 0 B
./frontend/.nuxt/dist/client/components/v-get-media-button.js 623 B 0 B
./frontend/.nuxt/dist/client/components/v-get-media-button.modern.js 628 B 0 B
./frontend/.nuxt/dist/client/components/v-grid-skeleton.js 1.55 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-grid-skeleton.modern.js 1.55 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-hide-button.js 594 B 0 B
./frontend/.nuxt/dist/client/components/v-hide-button.modern.js 592 B 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.js 4.28 kB 0 B
./frontend/.nuxt/dist/client/components/v-home-gallery.modern.js 4.26 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.js 1.82 kB 0 B
./frontend/.nuxt/dist/client/components/v-homepage-content.modern.js 1.79 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.js 2.24 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-cell.modern.js 2.23 kB 0 B
./frontend/.nuxt/dist/client/components/v-image-grid.js 4.53 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-image-grid.modern.js 4.41 kB +1 B (0%)
./frontend/.nuxt/dist/client/components/v-license-tab-panel.js 641 B 0 B
./frontend/.nuxt/dist/client/components/v-license-tab-panel.modern.js 648 B 0 B
./frontend/.nuxt/dist/client/components/v-load-more.js 1.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-load-more.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-details.js 5.88 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-details.modern.js 5.73 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-info.js 2.56 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-info.modern.js 2.54 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-license.js 931 B 0 B
./frontend/.nuxt/dist/client/components/v-media-license.modern.js 938 B 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.js 3 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-reuse.modern.js 2.97 kB 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tag.modern.js 420 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.js 885 B 0 B
./frontend/.nuxt/dist/client/components/v-media-tags.modern.js 883 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata-value.js 604 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata-value.modern.js 609 B 0 B
./frontend/.nuxt/dist/client/components/v-metadata.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/components/v-metadata.modern.js 1.32 kB 0 B
./frontend/.nuxt/dist/client/components/v-modal.js 982 B 0 B
./frontend/.nuxt/dist/client/components/v-modal.modern.js 973 B 0 B
./frontend/.nuxt/dist/client/components/v-no-results.js 2.67 kB 0 B
./frontend/.nuxt/dist/client/components/v-no-results.modern.js 2.03 kB 0 B
./frontend/.nuxt/dist/client/components/v-old-icon-button.js 853 B 0 B
./frontend/.nuxt/dist/client/components/v-old-icon-button.modern.js 846 B 0 B
./frontend/.nuxt/dist/client/components/v-radio.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-radio.modern.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.js 824 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio.modern.js 745 B 0 B
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.js 4.5 kB +3 B (0%)
./frontend/.nuxt/dist/client/components/v-related-audio/pages/search/audio.modern.js 4.37 kB +2 B (0%)
./frontend/.nuxt/dist/client/components/v-related-images.js 802 B 0 B
./frontend/.nuxt/dist/client/components/v-related-images.modern.js 718 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.js 996 B 0 B
./frontend/.nuxt/dist/client/components/v-report-desc-form.modern.js 999 B 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.js 2.05 kB 0 B
./frontend/.nuxt/dist/client/components/v-row-layout.modern.js 2.05 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.js 1.45 kB 0 B
./frontend/.nuxt/dist/client/components/v-safety-wall.modern.js 1.46 kB 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroll-button.modern.js 891 B 0 B
./frontend/.nuxt/dist/client/components/v-scroller.js 596 B 0 B
./frontend/.nuxt/dist/client/components/v-scroller.modern.js 592 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.js 616 B 0 B
./frontend/.nuxt/dist/client/components/v-search-results-title.modern.js 621 B 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.js 1.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-single-result-controls.modern.js 1.18 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.js 1.02 kB 0 B
./frontend/.nuxt/dist/client/components/v-sketch-fab-viewer.modern.js 916 B 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.js 1.06 kB 0 B
./frontend/.nuxt/dist/client/components/v-snackbar.modern.js 1.07 kB 0 B
./frontend/.nuxt/dist/client/components/v-source-creator-button.js 547 B 0 B
./frontend/.nuxt/dist/client/components/v-source-creator-button.modern.js 550 B 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.js 15.2 kB 0 B
./frontend/.nuxt/dist/client/components/v-sources-table.modern.js 15.3 kB 0 B
./frontend/.nuxt/dist/client/components/v-tag.js 411 B 0 B
./frontend/.nuxt/dist/client/components/v-tag.modern.js 416 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.js 307 B 0 B
./frontend/.nuxt/dist/client/components/v-warning-suppressor.modern.js 311 B 0 B
./frontend/.nuxt/dist/client/pages/about.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/about.modern.js 1.42 kB 0 B
./frontend/.nuxt/dist/client/pages/audio/_id/index.js 21 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/audio/_id/index.modern.js 19.7 kB -1 B (0%)
./frontend/.nuxt/dist/client/pages/feedback.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/feedback.modern.js 1.36 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.js 18.1 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/index.modern.js 16.7 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.js 5 kB 0 B
./frontend/.nuxt/dist/client/pages/image/_id/report.modern.js 4.75 kB 0 B
./frontend/.nuxt/dist/client/pages/index.js 6.41 kB 0 B
./frontend/.nuxt/dist/client/pages/index.modern.js 6.35 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.js 1.46 kB 0 B
./frontend/.nuxt/dist/client/pages/preferences.modern.js 1.46 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/privacy.modern.js 1.26 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.js 1.64 kB 0 B
./frontend/.nuxt/dist/client/pages/search-help.modern.js 1.62 kB 0 B
./frontend/.nuxt/dist/client/pages/search.js 5.82 kB 0 B
./frontend/.nuxt/dist/client/pages/search.modern.js 8.13 kB 0 B
./frontend/.nuxt/dist/client/pages/search/audio.js 499 B 0 B
./frontend/.nuxt/dist/client/pages/search/audio.modern.js 501 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.js 452 B 0 B
./frontend/.nuxt/dist/client/pages/search/image.modern.js 454 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.js 316 B 0 B
./frontend/.nuxt/dist/client/pages/search/index.modern.js 320 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.js 242 B 0 B
./frontend/.nuxt/dist/client/pages/search/model-3d.modern.js 246 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.js 240 B 0 B
./frontend/.nuxt/dist/client/pages/search/video.modern.js 243 B 0 B
./frontend/.nuxt/dist/client/pages/sensitive-content.js 1.52 kB 0 B
./frontend/.nuxt/dist/client/pages/sensitive-content.modern.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.js 1.53 kB 0 B
./frontend/.nuxt/dist/client/pages/sources.modern.js 1.54 kB 0 B
./frontend/.nuxt/dist/client/runtime.js 2.87 kB 0 B
./frontend/.nuxt/dist/client/runtime.modern.js 2.87 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.js 69 kB 0 B
./frontend/.nuxt/dist/client/vendors/app.modern.js 68.5 kB 0 B

compressed-size-action

@obulat obulat self-assigned this Nov 29, 2023
AetherUnbound
AetherUnbound approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use throttling in the browser developer tools if your network is too fast to see the loading skeletons.

Wow I had no idea this existed, so cool!!

The skeleton does show up for me when I try to run a search 🦴

@obulat obulat merged commit 96d9781 into main Nov 30, 2023
75 checks passed
@obulat obulat deleted the fix/skeletons branch November 30, 2023 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvkb dhruvkb dhruvkb approved these changes

@AetherUnbound AetherUnbound AetherUnbound approved these changes

Assignees

@obulat obulat

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Openverse PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obulat @AetherUnbound @dhruvkb