Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add or update runbooks for alarms of anomalous behavior #3420

Merged
merged 7 commits into from
Dec 6, 2023

Conversation

krysal
Copy link
Member

@krysal krysal commented Nov 29, 2023

Fixes

Pairing PR for WordPress/openverse-infrastructure#708 so it's related to the same issues:
Related to #2500 by @sarayourfriend
Related to #2504 by @sarayourfriend
Related to #2505 by @sarayourfriend

Description

Add the runbooks for anomalous behavior alarms, for both the API and Nuxt app, deleting the now unuseful *_request_count_above_threshold runbooks, due to these alarms being deleted.

Testing Instructions

Just proofread the docs from the generated links in a comment below.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🌟 goal: addition Addition of new feature 📄 aspect: text Concerns the textual material in the repository 🧱 stack: documentation Related to Sphinx documentation labels Nov 29, 2023
@krysal krysal requested a review from a team as a code owner November 29, 2023 23:37
@krysal krysal requested review from fcoveram and obulat November 29, 2023 23:37
Copy link

github-actions bot commented Nov 29, 2023

Full-stack documentation: https://docs.openverse.org/_preview/3420

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

New files ➕:

Changed files 🔄:

@krysal krysal mentioned this pull request Nov 30, 2023
1 task
@fcoveram fcoveram removed their request for review December 1, 2023 09:36
@krysal krysal requested a review from dhruvkb December 4, 2023 16:33
Copy link
Collaborator

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@krysal krysal force-pushed the add/monitoring_runbooks branch from a81ef1e to 1808696 Compare December 5, 2023 23:42
@openverse-bot
Copy link
Collaborator

Based on the high urgency of this PR, the following reviewers are being gently reminded to review this PR:

@obulat
@dhruvkb
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with high urgency are expected to be reviewed within 2 weekday(s)2.

@krysal, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

  1. Specifically, Saturday and Sunday.

  2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range.

@krysal krysal force-pushed the add/monitoring_runbooks branch 2 times, most recently from 2cc42ae to 9935e04 Compare December 6, 2023 20:38
@krysal krysal force-pushed the add/monitoring_runbooks branch from 9935e04 to fcc24ef Compare December 6, 2023 21:02
@krysal
Copy link
Member Author

krysal commented Dec 6, 2023

Rebased with main and fixed the status of the P99 Nuxt alarms. Merging now.

@krysal krysal merged commit cd869bf into main Dec 6, 2023
39 checks passed
@krysal krysal deleted the add/monitoring_runbooks branch December 6, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📄 aspect: text Concerns the textual material in the repository 🌟 goal: addition Addition of new feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: documentation Related to Sphinx documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants