-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Rawpixel image URLs for ingestion #3669
Update Rawpixel image URLs for ingestion #3669
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution @rawpixel-vincent! 😄 I have a few notes, the largest being which field we set for the thumbnail value. Let me know if any of these could use further explanations!
Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR: @krysal Excluding weekend1 days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)2. @rawpixel-vincent, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings. Footnotes
|
Drafting until feedback can be addressed! |
Co-authored-by: Madison Swain-Bowden <bowdenm@spu.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look great, thanks so much @rawpixel-vincent! I was able to run this locally and confirm that the primary & thumbnail URLs don't have the watermark 🚀 Can't thank you enough for your assist with the domain knowledge on the Rawpixel front on this one 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests perfectly for me -- thanks @rawpixel-vincent! 🚀
Fixes
Related to #3573 by @fcoveram
Description
Important: if the webp format is problematic, full_size_option can be replaced by
image_1000
(its similar toimage_social_landscape
but doesn't imply orientation is a factor)Ran the ingestion_server tests and catalog test locally.
Testing Instructions
Test the rawpixel image source are displayed properly and without watermark after ingestion.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin