Add check to skip toggling CloudWatch alarms

[krysal]

Fixes

Follow up to #3652.

Description

@AetherUnbound mentioned in the PR above a problem running the data refresh locally when AWS credentials aren't set (as is usual locally, since they are not necessary): #3652 (comment)

This PR adds an Airflow variable, AIRFLOW_VAR_TOGGLE_CLOUDWATCH_ALARMS, to decide when to actually modify Cloudwatch alarms, and change the connection to CloudWatch to use a more idiomatic Airflow AWS connection with a hook.

Testing Instructions

Connection

1. To test the AWS connection, set the AIRFLOW_CONN_AWS_CLOUDWATCH variable with the required credentials as shown in the env.example file. You could also generate it using this snippet to create Connection and convert to URI.
2. Run the catalog and ingestion server stack.

just up

3. Run a data_refresh DAG (audio or image), wait for it to finish and then observe in CloudWatch the updates of the alarm in the History tab: ES Production CPU utilization above 50%

Config for whether to toggle the alarm

1. Add the new variable through the Airflow UI, Header menu > Admin > Variables, with the value false.

TOGGLE_CLOUDWATCH_ALARMS

2. Run a data refresh again and observe the tasks for enabling/disabling the alarm are skipped.

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[github-actions]

Full-stack documentation: https://docs.openverse.org/_preview/3682

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Changed files 🔄:

• https://docs.openverse.org/_preview/3682/catalog/reference/DAGs.html

[stacimc]

Approving to unblock local testing of the data refreshes -- good catch @AetherUnbound, I did not think of that! I do think it would be preferable to actually skip the tasks if possible.

[dhruvkb]

Sorry for the drive-by review but I find the name SKIP_TOGGLING... a bit confusing like a multiple negative. I feel like ENABLE_TOGGLING... or TOGGLE... would be clearer. This would default to true so that the outcome is the same as SKIP_TOGGLING... that defaults to false.

[krysal]

This is good to go now! Thanks for the suggestions; they are excellent! I am asking for a review from @AetherUnbound, as you may want to check this too.

[AetherUnbound]

I've got a few small, suggested changes. Thanks for modifying this to use the idiomatic approach! 😄

[AetherUnbound]

I tried running this locally, but it looks like if the disable alarms tasks is skipped, it skips the trigger ingest upstream step too. I think we'll need to change the trigger rule on that one as well!

[krysal]

@AetherUnbound Ah, good catch! They were supposed to inherit the TriggerRule from the group task 🤔 Anyway, I changed it.

[openverse-bot]

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@dhruvkb
@stacimc
@AetherUnbound
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 4 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)².

@krysal, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Footnotes

1. Specifically, Saturday and Sunday. ↩

2. For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

[stacimc]

Updates look great, I'm really excited to get this back in!

[AetherUnbound]

Local testing now works well for me with skipping the alarms steps, thanks for fixing that! This is good to go IMO!