Remove needs db and add patch

[ngken0995]

Fixes

Fixes #3436 by @dhruvkb

Description

Remove needs_db because ES hit will alway map to DB result. Creating expected data by storing them in pickle file and retrieving those data in testing with open file and use patch to mock get_db_result return value.

Testing Instructions

just api/test

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[dhruvkb]

In test_auth.py we're not testing for the contents of the results so for those tests, mocking get_db_results to return the input argument results as-is would've worked.

[dhruvkb]

I have small change, but otherwise it looks good to me. Thanks for the contribution and for redoing the work based on reviews @ngken0995. The PR is almost ready to go 🚀!

[AetherUnbound]

These changes look great, thanks for making them @ngken0995!

[dhruvkb]

LGTM! This is great.