Add the I
rules to enable import sorting
#3700
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #3695 by @stacimc
Description
This PR adds the missing ruleset for isort (
I
) to Ruff. This reenables import sorting and creates a pretty big diff. Also it addstest
(which is our own module) to known, first-party packages so that makes the diff even longer.PS: I created #3546 so I knew where to look.
Testing Instructions
Verify the changes in
pyproject.toml
and ensure that lint checks are passing. You can try to repro the link issue and verify it cannot be reproduced on this branch. Running the following command should reorder imports (almost immediately!) after you've moved them around.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin