Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the I rules to enable import sorting #3700

Closed
wants to merge 3 commits into from
Closed

Add the I rules to enable import sorting #3700

wants to merge 3 commits into from

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jan 24, 2024

Fixes

Fixes #3695 by @stacimc

Description

This PR adds the missing ruleset for isort (I) to Ruff. This reenables import sorting and creates a pretty big diff. Also it adds test (which is our own module) to known, first-party packages so that makes the diff even longer.

PS: I created #3546 so I knew where to look.

Testing Instructions

Verify the changes in pyproject.toml and ensure that lint checks are passing. You can try to repro the link issue and verify it cannot be reproduced on this branch. Running the following command should reorder imports (almost immediately!) after you've moved them around.

just lint ruff

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested review from a team as code owners January 24, 2024 07:38
@github-actions github-actions bot added 🧱 stack: api Related to the Django API 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: mgmt Related to repo management and automations labels Jan 24, 2024
@openverse-bot openverse-bot added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Jan 24, 2024
@dhruvkb dhruvkb closed this Jan 24, 2024
@dhruvkb
Copy link
Member Author

dhruvkb commented Jan 24, 2024

Duplicated effort. I should've seen #3698 but the original issue was not assigned to anyone 😔.

@fcoveram fcoveram removed their request for review January 24, 2024 09:41
@dhruvkb dhruvkb deleted the fix_isort branch January 24, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: api Related to the Django API 🧱 stack: catalog Related to the catalog and Airflow DAGs 🧱 stack: ingestion server Related to the ingestion/data refresh server 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Ruff failing to correctly sort imports
2 participants