-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace docker-compose with docker compose in just scripts and docs #4017
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/4017 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. Changed files 🔄:
|
Signed-off-by: Olga Bulat <obulat@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look good to me.
The underscore and dash change is a non-issue for us especially if we use the docker compose exec
command with service names instead of container names.
I have more confidence in the changes because many folks on the team, myself included, have been using Compose v2 for a while and it has not affected anything for us.
I do have some nits about capitalisation but those are not blockers. The blocker is the V2 → v3 upgrade in docker-compose.yml
.
Co-authored-by: Dhruv Bhanushali <hi@dhruvkb.dev>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change! I encountered it yesterday but it was successful after a second run. Weird!
Fixes
Related to #3876 by @zackkrida
Description
This PR only replaces
docker-compose
injustfile
s and documentation withdocker compose
.It does not simplify the
docker ps
script.@zackkrida mentions the replacement of underscores with dashes for container names in the issue: should this be done manually? Would it also affect production?
I think it's best to keep the scope of this PR small to fix the critical issue of CI failures due to
docker-compose
command not being found.Testing Instructions
The CI should pass.
All of the
just
commands that used to usedocker-compose
should work as usual.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin