Use "audio track(s)" to refer to individual audio works #4037

Collins-Webdev · 2024-04-04T18:17:48Z

Update References to "Audio Track(s)" in English Text

Description

This pull request addresses issue #3972 by updating references to audio works to use the phrase "audio track(s)" instead of just "audio", following the convention established in issue #3941.

Changes Made

Replaced occurrences of "audio" with "audio track(s)" in the English text contained in en.json5.
Ensured that the updated references maintain readability and consistency throughout the project.
Verified the changes by running the project locally to ensure there are no visible errors.
Reviewed and adhered to the established code style of the repository.
No changes to tests or documentation were required for this update.

Checklist

My pull request has a descriptive title (not a vague title likeUpdate index.md).
My pull request targets the default branch of the repository (main) or a parent feature branch.
My commit messages follow best practices.
My code follows the established code style of the repository.
I added or updated tests for the changes I made (if applicable).
I added or updated documentation (if applicable).
I tried running the project locally and verified that there are no visible errors.
I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

dhruvkb · 2024-04-04T21:24:42Z

Hi @Collins-Webdev, could you update your PR description to use the pull request template? If you have any questions please let us know in the comments.

I'm labelling the PR as "🧹 status: ticket work required" in the meantime.

dhruvkb

The changes are good and you've made them in the exact right placc @Collins-Webdev! Thank you for the contributions.

However there are some grammatical issues that I have pointed out in the review. If you could please correct them that would be great. After you have made the text updates, you will need to update the snapshots (see the note about -u in the link) for the frontend tests to pass. Let us know in the comments if you need any help.

For now, I will convert this PR to a draft so that you can make the required changes and once you are done, you can mark is as ready for review, thanks!

dhruvkb · 2024-04-04T21:27:02Z

frontend/src/locales/scripts/en.json5

@@ -5,7 +5,7 @@
  },
  hero: {
    subtitle: "Explore more than 700 million creative works",
-    description: "An extensive library of free stock photos, images, and audio, available for free use.",
+    description: "An extensive library of free stock photos, images, and audio track, available for free use.",


The word "track" was not needed here as we are referring to the entire body of audio works. Please revert.

dhruvkb · 2024-04-04T21:27:33Z

frontend/src/locales/scripts/en.json5

@@ -80,14 +80,14 @@
    },
    collection: {
      content: {
-        a: "{openverse} searches across more than 700 million images and audio from open APIs and the {commonCrawl} dataset.",
+        a: "{openverse} searches across more than 700 million images and audio track from open APIs and the {commonCrawl} dataset.",


We would use the plural form of the word here as we are referring to more than one audio track in this string.

Suggested change

a: "{openverse} searches across more than 700 million images and audio track from open APIs and the {commonCrawl} dataset.",

a: "{openverse} searches across more than 700 million images and audio tracks from open APIs and the {commonCrawl} dataset.",

dhruvkb · 2024-04-04T21:27:57Z

frontend/src/locales/scripts/en.json5

        b: "We aggregate works from multiple public repositories, and facilitate reuse through features like one-click attribution.",
      },
    },
    planning: {
      content: {
        /** about.planning.content.a-c are parts of a single statement */
-        a: "Currently {openverse} only searches images and audio, with search for video provided through External Sources.",
+        a: "Currently {openverse} only searches images and audio track, with search for video provided through External Sources.",


Please use the plural form.

Suggested change

a: "Currently {openverse} only searches images and audio track, with search for video provided through External Sources.",

a: "Currently {openverse} only searches images and audio tracks, with search for video provided through External Sources.",

dhruvkb · 2024-04-04T21:28:29Z

frontend/src/locales/scripts/en.json5

-      audio: "Audio Sources",
+      audio: "Audio track Sources",


Please revert this change as "track" is not needed here. A source of audio tracks can be called an "audio source".

dhruvkb · 2024-04-04T21:29:53Z

frontend/src/locales/scripts/en.json5

+        count: "See {localeCount} audio track found for {query}.",
+        countMore: "See over {localeCount} audio track found for {query}.",


Please use the plural form.

Suggested change

count: "See {localeCount} audio track found for {query}.",

countMore: "See over {localeCount} audio track found for {query}.",

count: "See {localeCount} audio tracks found for {query}.",

countMore: "See over {localeCount} audio tracks found for {query}.",

dhruvkb · 2024-04-04T21:34:28Z

frontend/src/locales/scripts/en.json5

+          zero: "No audio track files provided by this source",
+          count: "{count} audio track file provided by this source|{count} audio track files provided by this source",
+          countMore: "Over {count} audio track files provided by this source",


The word "track" and "file" should not both be used as one removes the need for the other.

Suggested change

zero: "No audio track files provided by this source",

count: "{count} audio track file provided by this source|{count} audio track files provided by this source",

countMore: "Over {count} audio track files provided by this source",

zero: "No audio tracks provided by this source",

count: "{count} audio track provided by this source|{count} audio tracks provided by this source",

countMore: "Over {count} audio tracks provided by this source",

dhruvkb · 2024-04-04T21:35:14Z

frontend/src/locales/scripts/en.json5

+          zero: "No audio track files with the selected tag",
+          count: "{count} audio track file with the selected tag|{count} audio track files with the selected tag",
+          countMore: "Over {count} audio track files with the selected tag",


Same note as above^. The use of "track(s)" will eliminate the need for the word "file(s)".

dhruvkb · 2024-04-04T21:35:36Z

frontend/src/locales/scripts/en.json5

+          zero: "No audio track files by this creator.",
+          count: "{count} audio track file by this creator.|{count} audio track files by this creator.",
+          countMore: "Over {count} audio track files by this creator.",


Same note as above^. The use of "track(s)" will eliminate the need for the word "file(s)".

dhruvkb · 2024-04-04T21:36:11Z

frontend/src/locales/scripts/en.json5

-    audio: "Audio",
+    audio: "Audio track",


Please revert this change as we are referring to to the collection of all audio tracks so "Audio" is suitable here.

dhruvkb · 2024-04-04T21:36:25Z

frontend/src/locales/scripts/en.json5

@@ -1000,7 +1000,7 @@
    additional: "Coming soon",
    statusBeta: "Beta",
    seeImage: "See all images",
-    seeAudio: "See all audio",
+    seeAudio: "See all audio track",


Please use the plural form.

Suggested change

seeAudio: "See all audio track",

seeAudio: "See all audio tracks",

obulat · 2024-04-17T15:40:11Z

frontend/src/locales/scripts/en.json5

@@ -507,7 +507,7 @@
      title: "Source",
    },
    audioCategories: {
-      title: "Audio category",
+      title: "Audio track category",


Suggested change

title: "Audio track category",

title: "Audio category",

obulat · 2024-04-17T15:40:29Z

frontend/src/locales/scripts/en.json5

-        zero: "No audio found for {query}.",
-        count: "See {localeCount} audio found for {query}.",
-        countMore: "See over {localeCount} audio found for {query}.",
+        zero: "No audio track found for {query}.",


Suggested change

zero: "No audio track found for {query}.",

zero: "No audio tracks found for {query}.",

frontend/src/locales/scripts/en.json5

obulat · 2024-04-17T15:44:18Z

frontend/src/locales/scripts/en.json5

@@ -1142,7 +1142,7 @@
      creator: {
        audio: {
          zero: "No audio files by this creator.",
-          count: "{count} audio file by this creator.|{count} audio files by this creator.",
+          count: "{count} audio track file by this creator.|{count} audio track files by this creator.",


Suggested change

count: "{count} audio track file by this creator.|{count} audio track files by this creator.",

count: "{count} audio track by this creator.|{count} audio tracks by this creator.",

obulat · 2024-04-17T15:44:30Z

frontend/src/locales/scripts/en.json5

@@ -1142,7 +1142,7 @@
      creator: {
        audio: {
          zero: "No audio files by this creator.",


Suggested change

zero: "No audio files by this creator.",

zero: "No audio tracks by this creator.",

obulat · 2024-04-17T15:44:49Z

frontend/src/locales/scripts/en.json5

@@ -1154,7 +1154,7 @@
      source: {
        audio: {
          zero: "No audio files provided by this source",
-          count: "{count} audio file provided by this source|{count} audio files provided by this source",
+          count: "{count} audio file provided by this source|{count} audio track files provided by this source",


Suggested change

count: "{count} audio file provided by this source|{count} audio track files provided by this source",

count: "{count} audio track provided by this source|{count} audio tracks provided by this source",

obulat · 2024-04-17T15:45:07Z

frontend/src/locales/scripts/en.json5

@@ -1166,7 +1166,7 @@
      tag: {
        audio: {
          zero: "No audio files with the selected tag",
-          count: "{count} audio file with the selected tag|{count} audio files with the selected tag",
+          count: "{count} audio file with the selected tag|{count} audio track files with the selected tag",


Suggested change

count: "{count} audio file with the selected tag|{count} audio track files with the selected tag",

count: "{count} audio track with the selected tag|{count} audio tracks with the selected tag",

obulat

Thank you for all your work on this, @Collins-Webdev ! I've added several more suggestions for changes. After adding them, could you mark this PR "Ready for review" so that we can approve and merge it?

Collins-Webdev · 2024-04-19T22:47:47Z

Thank you for all your work on this, @Collins-Webdev ! I've added several more suggestions for changes. After adding them, could you mark this PR "Ready for review" so that we can approve and merge it?

Hello @obulat ,

It's a pleasure for me to be able to participate in such a large-scale project. I have taken your suggestions into account and made the necessary changes. Could you please review them and proceed with merging?
Thanks.

frontend/src/locales/scripts/en.json5

obulat

@Collins-Webdev, I added the whitespace changes to fix the linting step of the CI.

Now, the text of the about pages have changed, so we need to update the Visual regression testing snapshots. Here are instructions on how to do it: https://docs.openverse.org/frontend/guides/test.html#updating-snapshots

If you have any problems with this, please comment here - we can help or update for you.

openverse-bot · 2024-04-30T00:00:08Z

Based on the medium urgency of this PR, the following reviewers are being gently reminded to review this PR:

@AetherUnbound
@dhruvkb
This reminder is being automatically generated due to the urgency configuration.

Excluding weekend¹ days, this PR was ready for review 6 day(s) ago. PRs labelled with medium urgency are expected to be reviewed within 4 weekday(s)².

@Collins-Webdev, if this PR is not ready for a review, please draft it to prevent reviewers from getting further unnecessary pings.

Specifically, Saturday and Sunday. ↩
For the purpose of these reminders we treat Monday - Friday as weekdays. Please note that the operation that generates these reminders runs at midnight UTC on Monday - Friday. This means that depending on your timezone, you may be pinged outside of the expected range. ↩

obulat

I updated the failing snapshots, and the CI now passes.

Thank you for your contribution, @Collins-Webdev 🎉

dhruvkb

Thank you for the contribution @Collins-Webdev! Also thank you @obulat for making the pending changes.

Hi there, I've made some enhancements to the code to address the issue described in WordPress#3941. Following the convention established, I updated references to audio works to use the phrase "audio track(s)" instead of just "audio". Please review the changes and let me know if there are any further adjustments needed. Thank you for considering my contribution.

Signed-off-by: Olga Bulat <obulat@gmail.com>

Collins-Webdev requested a review from a team as a code owner April 4, 2024 18:17

Collins-Webdev requested review from AetherUnbound and dhruvkb April 4, 2024 18:17

openverse-bot added the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Apr 4, 2024

Collins-Webdev mentioned this pull request Apr 4, 2024

Update references to audio works to use "audio track(s)" #3972

Closed

dhruvkb requested changes Apr 4, 2024

View reviewed changes

dhruvkb changed the title ~~Issue #3941 resolved~~ Use "audio track(s)" to refer to individual audio works Apr 4, 2024

openverse-bot added the 🕹 aspect: interface Concerns end-users' experience with the software label Apr 4, 2024

dhruvkb marked this pull request as draft April 4, 2024 21:44

obulat removed the 🧹 status: ticket work required Needs more details before it can be worked on label Apr 5, 2024

Collins-Webdev requested a review from dhruvkb April 5, 2024 16:46

obulat reviewed Apr 17, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

obulat reviewed Apr 17, 2024

View reviewed changes

obulat requested changes Apr 18, 2024

View reviewed changes

Collins-Webdev requested a review from obulat April 19, 2024 22:53

obulat reviewed Apr 20, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

obulat reviewed Apr 20, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

obulat reviewed Apr 20, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

obulat reviewed Apr 20, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

Collins-Webdev marked this pull request as ready for review April 20, 2024 18:58

Collins-Webdev requested a review from obulat April 20, 2024 18:58

obulat reviewed Apr 22, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

obulat assigned obulat and Collins-Webdev and unassigned obulat Apr 22, 2024

obulat reviewed Apr 22, 2024

View reviewed changes

frontend/src/locales/scripts/en.json5 Outdated Show resolved Hide resolved

obulat requested changes Apr 22, 2024

View reviewed changes

obulat force-pushed the improvements branch from 5b2f7ce to 16715fb Compare April 29, 2024 16:58

obulat approved these changes Apr 30, 2024

View reviewed changes

obulat force-pushed the improvements branch from 5f1cda4 to 9885016 Compare April 30, 2024 04:14

dhruvkb approved these changes Apr 30, 2024

View reviewed changes

Collins-Webdev and others added 13 commits April 30, 2024 18:22

Grammatical issues resolved.

cefcc17

Fixed grammatical issues

a9d3d61

Fix linting error

aa2a9ec

Suggestions added

09368e7

Changes made.

6dde391

Changes made.

7ba1a56

Remove unnecessary 'files'

44d429c

Changes made.

85de2d1

Add trailing blank line

c0d21f3

Add missing space

2fa17e6

Add a missing article

99b2084

Signed-off-by: Olga Bulat <obulat@gmail.com>

Update snapshots

66bdab0

Signed-off-by: Olga Bulat <obulat@gmail.com>

obulat force-pushed the improvements branch from 9885016 to 66bdab0 Compare April 30, 2024 15:22

obulat merged commit d181f40 into WordPress:main Apr 30, 2024
40 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use "audio track(s)" to refer to individual audio works #4037

Use "audio track(s)" to refer to individual audio works #4037

Collins-Webdev commented Apr 4, 2024 •

edited by obulat

Loading

dhruvkb commented Apr 4, 2024 •

edited

Loading

dhruvkb left a comment •

edited

Loading

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

dhruvkb Apr 4, 2024

obulat Apr 17, 2024

obulat Apr 17, 2024

obulat Apr 17, 2024

obulat Apr 17, 2024

obulat Apr 17, 2024

obulat Apr 17, 2024

obulat left a comment

Collins-Webdev commented Apr 19, 2024

obulat left a comment

openverse-bot commented Apr 30, 2024

obulat left a comment

dhruvkb left a comment

	a: "{openverse} searches across more than 700 million images and audio track from open APIs and the {commonCrawl} dataset.",
	a: "{openverse} searches across more than 700 million images and audio tracks from open APIs and the {commonCrawl} dataset.",

	a: "Currently {openverse} only searches images and audio track, with search for video provided through External Sources.",
	a: "Currently {openverse} only searches images and audio tracks, with search for video provided through External Sources.",

		count: "See {localeCount} audio track found for {query}.",
		countMore: "See over {localeCount} audio track found for {query}.",

	seeAudio: "See all audio track",
	seeAudio: "See all audio tracks",

	zero: "No audio track found for {query}.",
	zero: "No audio tracks found for {query}.",

	count: "{count} audio track file by this creator.\|{count} audio track files by this creator.",
	count: "{count} audio track by this creator.\|{count} audio tracks by this creator.",

	zero: "No audio files by this creator.",
	zero: "No audio tracks by this creator.",

	count: "{count} audio file provided by this source\|{count} audio track files provided by this source",
	count: "{count} audio track provided by this source\|{count} audio tracks provided by this source",

	count: "{count} audio file with the selected tag\|{count} audio track files with the selected tag",
	count: "{count} audio track with the selected tag\|{count} audio tracks with the selected tag",

Use "audio track(s)" to refer to individual audio works #4037

Use "audio track(s)" to refer to individual audio works #4037

Conversation

Collins-Webdev commented Apr 4, 2024 • edited by obulat Loading

Description

Changes Made

Checklist

Developer Certificate of Origin

dhruvkb commented Apr 4, 2024 • edited Loading

dhruvkb left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

obulat left a comment

Choose a reason for hiding this comment

Collins-Webdev commented Apr 19, 2024

obulat left a comment

Choose a reason for hiding this comment

openverse-bot commented Apr 30, 2024

Footnotes

obulat left a comment

Choose a reason for hiding this comment

dhruvkb left a comment

Choose a reason for hiding this comment

Collins-Webdev commented Apr 4, 2024 •

edited by obulat

Loading

dhruvkb commented Apr 4, 2024 •

edited

Loading

dhruvkb left a comment •

edited

Loading