-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions how to run ingestion script from command line #4083
Add instructions how to run ingestion script from command line #4083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I am going to push two very small changes to align with our other "run this command" code blocks, but otherwise this is great. Thanks very much for the contribution @kuephi 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @kuephi! Unfortunately, many of the catalog's provider scripts depend on Airflow and must be run from within the Docker stack. The issue (#2799) describes how this might be accomplished. Do you mind altering these instructions to direct users how to use the docker-related just
commands instead? E.g. just catalog/run bash
and then the python command needed to run the provider.
will have a look @AetherUnbound |
…iep to run script in the docker stack
changed it according to your comment. had to add a new command to the catalog justfile too. Hope this will do it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the change, this looks great! I have one change requested around spelling. Also, it looks like linting is failing - would you be able to run just lint
locally and address/commit the changes it's suggesting?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! 😄
Fixes
Fixes #2799 by @stacimc
Description
Added documentation how to run ingestion script via cli
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin