Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the additional search views flag #4222

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Apr 29, 2024

Fixes

Fixes #3918 by @obulat

Description

This PR removes the flag from the Nuxt app.

It also removes the old snapshots. I didn't rename the single result snapshots (removing -with-additional-search-views) here to make it easier to review. We can rename them in a small follow-up PR.

Testing Instructions

The CI should pass, single result, collection and sources pages should work as expected. The flag should not be displayed on the /preferences page

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (if applicable).

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions github-actions bot added 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend labels Apr 29, 2024
@openverse-bot openverse-bot added 🟨 priority: medium Not blocking but should be addressed soon 🧰 goal: internal improvement Improvement that benefits maintainers, not users 💻 aspect: code Concerns the software code in the repository labels Apr 29, 2024
Copy link

Full-stack documentation: https://docs.openverse.org/_preview/4222

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

}
for (const [feature, status] of Object.entries(options.features)) {
features[feature] = status
}
cookiesToSet.features = features
} else {
cookiesToSet.features = { fetch_sensitive: "off" }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know how, but it seems that the sensitive tests are changing the state for other tests, and make them add mature=true to requests. To prevent that, we always set fetch_sensitive to false if no features are passed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make an issue for this?

@obulat obulat marked this pull request as ready for review April 29, 2024 16:05
@obulat obulat requested a review from a team as a code owner April 29, 2024 16:05
@obulat obulat requested review from zackkrida and dhruvkb April 29, 2024 16:05
@obulat obulat force-pushed the remove/additional_search_views_flag branch from 88aa997 to fe30f42 Compare April 29, 2024 16:05
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see so many unused code branches removed. LGTM!

@obulat obulat force-pushed the remove/additional_search_views_flag branch from fe30f42 to 0327438 Compare April 30, 2024 05:33
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat force-pushed the remove/additional_search_views_flag branch from 0327438 to 1c56975 Compare April 30, 2024 14:37
@obulat obulat merged commit cb5eb2f into main Apr 30, 2024
40 checks passed
@obulat obulat deleted the remove/additional_search_views_flag branch April 30, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: documentation Related to Sphinx documentation 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove the additional_search_views flag from the frontend
4 participants