-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the additional search views flag #4222
Conversation
Full-stack documentation: https://docs.openverse.org/_preview/4222 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
} | ||
for (const [feature, status] of Object.entries(options.features)) { | ||
features[feature] = status | ||
} | ||
cookiesToSet.features = features | ||
} else { | ||
cookiesToSet.features = { fetch_sensitive: "off" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know how, but it seems that the sensitive tests are changing the state for other tests, and make them add mature=true
to requests. To prevent that, we always set fetch_sensitive
to false if no features are passed here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make an issue for this?
88aa997
to
fe30f42
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice to see so many unused code branches removed. LGTM!
fe30f42
to
0327438
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: Olga Bulat <obulat@gmail.com>
0327438
to
1c56975
Compare
Fixes
Fixes #3918 by @obulat
Description
This PR removes the flag from the Nuxt app.
It also removes the old snapshots. I didn't rename the single result snapshots (removing
-with-additional-search-views
) here to make it easier to review. We can rename them in a small follow-up PR.Testing Instructions
The CI should pass, single result, collection and sources pages should work as expected. The flag should not be displayed on the
/preferences
pageChecklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin