Drop ORDER BY clause from copy step when adding a limit

[krysal]

Fixes

Fixes #4381 by @krysal

Description

As explained in the issue, we're ditching this clause here.

Testing Instructions

1. Set the environment variable for the limit to a number lower than 5000. Eg.:

DATA_REFRESH_LIMIT=1000

2. Start a data refresh

just api/up && just docker/es/delete-index image-init && \
just ingestion_server/ingest-upstream

3. Wait for the process to finish; locally, it is very quick (less than a minute), and promote the table.

just ingestion_server/promote

4. Verify the number of images is correct with just api/pgcli and

SELECT COUNT(*) FROM image;

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (just catalog/generate-docs for catalog
  PRs) or the media properties generator (just catalog/generate-docs media-props
  for the catalog or just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[AetherUnbound]

The code looks right, and thanks for the testing steps! I was able to verify it works locally, LGTM 🚀

[zackkrida]

The changeset looks fine so I don't want to block. LGTM! I am having an issue locally that must be unrelated. I am unable to get anything other than 5000 from SELECT COUNT(*) from image;. Is that confirmed to be working locally for you @krysal and @AetherUnbound?

[krysal]

@zackkrida It works for me, where did you set DATA_REFRESH_LIMIT? I forgot to add that it should go in the ingestion_server/.env file.