Update ingestion server removal IP with EC2 approach

[stacimc]

Fixes

Description

Updates the ingestion server removal IP to reflect changes discussed here (moving away from the ASG approach and back to managing EC2 instances more directly).

Checklist

• My pull request has a descriptive title (not a vague title likeUpdate index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.
• I ran the DAG documentation generator (./ov just catalog/generate-docs for catalog
  PRs) or the media properties generator (./ov just catalog/generate-docs media-props
  for the catalog or ./ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[stacimc]

Adding @sarayourfriend as a reviewer because of infrastructure implications, and since we first discussed this approach! Also pinging @AetherUnbound for the catalog.

[github-actions]

Full-stack documentation: https://docs.openverse.org/_preview/4615

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Changed files 🔄:

• https://docs.openverse.org/_preview/4615/projects/proposals/ingestion_server_removal/20240328-implementation_plan_ingestion_server_removal.html

[sarayourfriend]

Great! Just two small comments, neither blocking. This is a great simplification and is a good step in the right direction to eventually remove the API from the workers, and just have them immediately start their job when starting. Doing that would make it easy to use spot instances for this work, saving us a huge sum of money on each run.

[sarayourfriend]

👍

[AetherUnbound]

Thanks for making this explicit!

[sarayourfriend]

I've opened a PR with the required infrastructure code change to make this happen: https://github.com/WordPress/openverse-infrastructure/pull/980

[zackkrida]

Nice, this looks good. I've been meaning to suggest we find a standardized way to denote changes to our IPs and other documents. Perhaps a "changelog" section that links to the PR file diff and summarizes the changes?

What you've done seems sufficient for now, but reminded me to create an issue for this, so thanks 😄

#4619

[AetherUnbound]

No objections, only one small formatting suggestion I found while looking at the rendered document. Looks good!

[AetherUnbound]

Thanks for making this explicit!