Skip to content

Remove obsolete cache invalidation code from get_sources (fixes #706) #5042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

aditya-raj-panjiyara
Copy link
Contributor

Fixes

Fixes #706 by @dhruvkb

Description

This PR removes the obsolete cache invalidation logic from the get_sources
function in search_controller.py. The code was originally added to handle
the migration of caches to a new format but is no longer necessary.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

The transitional cache invalidation code used for migrating to the new
cache format is no longer needed. This change simplifies the codebase
and removes unnecessary cache operations.
The transitional cache invalidation code used for migrating to the new
cache format is no longer needed. This change simplifies the codebase
and removes unnecessary cache operations.
@aditya-raj-panjiyara aditya-raj-panjiyara requested a review from a team as a code owner October 17, 2024 10:18
@aditya-raj-panjiyara aditya-raj-panjiyara requested review from krysal and stacimc and removed request for a team October 17, 2024 10:18
@openverse-bot openverse-bot added 🧱 stack: api Related to the Django API 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Oct 17, 2024
@obulat obulat removed the request for review from stacimc October 17, 2024 15:04
@aditya-raj-panjiyara aditya-raj-panjiyara closed this by deleting the head repository Oct 17, 2024
@obulat
Copy link
Contributor

obulat commented Oct 18, 2024

Hi @dryruffian, was there any problem with this PR? It was looking really good.
I removed the request for review from one of the maintainers, but another maintainer would have provided the review instead.

@aditya-raj-panjiyara
Copy link
Contributor Author

aditya-raj-panjiyara commented Oct 18, 2024

@obulat
I was able to run the API test locally and it passed. However, when I tried to lint the file, I got an error. I'll create a PR soon with the same changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Remove transition code in search controller
3 participants