-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add XS snapshots for dark mode #5053
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟨 priority: medium
Not blocking but should be addressed soon
✨ goal: improvement
Improvement to an existing user-facing feature
💻 aspect: code
Concerns the software code in the repository
🧱 stack: frontend
Related to the Nuxt frontend
labels
Oct 18, 2024
Latest k6 run output1
Footnotes
|
obulat
force-pushed
the
add/dark-mode-snapshots-xs
branch
2 times, most recently
from
October 18, 2024 19:36
a6b48f5
to
d8984f2
Compare
obulat
force-pushed
the
add/dark-mode-snapshots-xs
branch
from
October 18, 2024 19:48
d8984f2
to
55c71ad
Compare
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
obulat
force-pushed
the
add/dark-mode-snapshots-xs
branch
from
October 19, 2024 04:29
55c71ad
to
bbb6bf1
Compare
dhruvkb
approved these changes
Oct 19, 2024
Danil49
pushed a commit
to Danil49/openverse
that referenced
this pull request
Oct 29, 2024
* Add xs dark snapshots Signed-off-by: Olga Bulat <obulat@gmail.com> * Add xs storybook dark snapshots Signed-off-by: Olga Bulat <obulat@gmail.com> --------- Signed-off-by: Olga Bulat <obulat@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
💻 aspect: code
Concerns the software code in the repository
✨ goal: improvement
Improvement to an existing user-facing feature
🟨 priority: medium
Not blocking but should be addressed soon
🧱 stack: frontend
Related to the Nuxt frontend
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #4305 by @zackkrida
Description
This PR adds snapshots for XS breakpoint.
Testing Instructions
There should only be dark snapshots added (and the change in
breakpoints.ts
file).The CI should pass.
If there are any problems with the UI, the problems should be noted but not fixed in this PR.
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin