Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XS snapshots for dark mode #5053

Merged
merged 2 commits into from
Oct 19, 2024
Merged

Add XS snapshots for dark mode #5053

merged 2 commits into from
Oct 19, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 18, 2024

Fixes

Related to #4305 by @zackkrida

Description

This PR adds snapshots for XS breakpoint.

Testing Instructions

There should only be dark snapshots added (and the change in breakpoints.ts file).
The CI should pass.
If there are any problems with the UI, the problems should be noted but not fixed in this PR.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Oct 18, 2024
@obulat obulat self-assigned this Oct 18, 2024
Copy link

github-actions bot commented Oct 18, 2024

Latest k6 run output1

$     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.9 GB  8.1 MB/s
     data_sent......................: 1.0 MB  4.6 kB/s
     http_req_blocked...............: avg=16.34µs  min=1.95µs  med=3.63µs   max=10.77ms p(90)=5.09µs   p(95)=5.47µs  
     http_req_connecting............: avg=11.22µs  min=0s      med=0s       max=8.64ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=594.35ms min=25.78ms med=528.53ms max=2.47s   p(90)=1.11s    p(95)=1.21s   
       { expected_response:true }...: avg=594.35ms min=25.78ms med=528.53ms max=2.47s   p(90)=1.11s    p(95)=1.21s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=136.77µs min=40.36µs med=109.55µs max=18.23ms p(90)=172.71µs p(95)=208.69µs
     http_req_sending...............: avg=22.8µs   min=5.8µs   med=18.8µs   max=12.69ms p(90)=24.22µs  p(95)=26.21µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=594.19ms min=25.67ms med=528.39ms max=2.47s   p(90)=1.11s    p(95)=1.21s   
     http_reqs......................: 8000    34.965353/s
     iteration_duration.............: avg=3.97s    min=1.13s   med=3.41s    max=12.02s  p(90)=8.6s     p(95)=9.19s   
     iterations.....................: 1200    5.244803/s
     vus............................: 6       min=6       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat force-pushed the add/dark-mode-snapshots-xs branch 2 times, most recently from a6b48f5 to d8984f2 Compare October 18, 2024 19:36
@obulat obulat marked this pull request as ready for review October 18, 2024 19:48
@obulat obulat requested a review from a team as a code owner October 18, 2024 19:48
@obulat obulat requested review from krysal and dhruvkb October 18, 2024 19:48
@obulat obulat force-pushed the add/dark-mode-snapshots-xs branch from d8984f2 to 55c71ad Compare October 18, 2024 19:48
Signed-off-by: Olga Bulat <obulat@gmail.com>
Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat force-pushed the add/dark-mode-snapshots-xs branch from 55c71ad to bbb6bf1 Compare October 19, 2024 04:29
@obulat obulat merged commit 5ee9e43 into main Oct 19, 2024
48 checks passed
@obulat obulat deleted the add/dark-mode-snapshots-xs branch October 19, 2024 13:41
Danil49 pushed a commit to Danil49/openverse that referenced this pull request Oct 29, 2024
* Add xs dark snapshots

Signed-off-by: Olga Bulat <obulat@gmail.com>

* Add xs storybook dark snapshots

Signed-off-by: Olga Bulat <obulat@gmail.com>

---------

Signed-off-by: Olga Bulat <obulat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants