Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix token in #4991 #5062

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Fix token in #4991 #5062

merged 1 commit into from
Oct 21, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 21, 2024

Fixes

Fast follow on #4991

Description

convictional/trigger-workflow-and-wait expects github_token, and we are sending token.
Screenshot 2024-10-21 at 6 54 27 PM

Testing Instructions

Merge and see

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Olga Bulat <obulat@gmail.com>
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: frontend Related to the Nuxt frontend labels Oct 21, 2024
@obulat obulat requested a review from a team as a code owner October 21, 2024 15:56
@obulat obulat requested review from krysal and dhruvkb and removed request for a team October 21, 2024 15:56
@openverse-bot openverse-bot added the 🧱 stack: mgmt Related to repo management and automations label Oct 21, 2024
@obulat obulat self-assigned this Oct 21, 2024
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 8000      ✗ 0   
     data_received..................: 1.9 GB  8.7 MB/s
     data_sent......................: 1.0 MB  4.9 kB/s
     http_req_blocked...............: avg=7.48µs   min=1.86µs   med=3.72µs   max=3.6ms   p(90)=5.3µs    p(95)=5.8µs   
     http_req_connecting............: avg=3.3µs    min=0s       med=0s       max=3.57ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=555.51ms min=35.3ms   med=493.82ms max=2.3s    p(90)=1.03s    p(95)=1.14s   
       { expected_response:true }...: avg=555.51ms min=35.3ms   med=493.82ms max=2.3s    p(90)=1.03s    p(95)=1.14s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 8000
     http_req_receiving.............: avg=142.84µs min=43.1µs   med=113.03µs max=21.87ms p(90)=180.61µs p(95)=216.02µs
     http_req_sending...............: avg=24.83µs  min=7.4µs    med=19.2µs   max=19.42ms p(90)=25.14µs  p(95)=27.28µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=555.34ms min=35.18ms  med=493.6ms  max=2.3s    p(90)=1.03s    p(95)=1.14s   
     http_reqs......................: 8000    37.267755/s
     iteration_duration.............: avg=3.71s    min=816.94ms med=3.32s    max=12.51s  p(90)=7.85s    p(95)=8.54s   
     iterations.....................: 1200    5.590163/s
     vus............................: 10      min=10      max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat merged commit f0d9a4c into main Oct 21, 2024
90 checks passed
@obulat obulat deleted the fix/k6_staging_test branch October 21, 2024 16:25
Danil49 pushed a commit to Danil49/openverse that referenced this pull request Oct 29, 2024
Signed-off-by: Olga Bulat <obulat@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend 🧱 stack: mgmt Related to repo management and automations
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants