Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure poke interval for the filtered index creation by environment #5114

Merged
merged 3 commits into from
Oct 31, 2024

Conversation

stacimc
Copy link
Collaborator

@stacimc stacimc commented Oct 30, 2024

Fixes

Description

Updates the create_and_populate_filtered_index.trigger_and_wait_for_reindex.wait_for_reindex task to take its poke interval from the data refresh config. This allows us to poke more frequently for the audio filtered index, as it typically completes in well under thirty minutes.

Testing Instructions

Run the staging_audio_data_refresh and staging_image_data_refresh locally. Ensure they pass. The filtered index is created so quickly it's difficult to verify the behavior of the poke interval locally, but you can check the task instance details to verify that it is now set dynamically.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟧 priority: high Stalls work on the project or its dependents ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Oct 30, 2024
@stacimc stacimc self-assigned this Oct 30, 2024
@stacimc stacimc requested a review from a team as a code owner October 30, 2024 20:39
@stacimc stacimc requested review from krysal and obulat and removed request for a team October 30, 2024 20:39
@stacimc stacimc marked this pull request as draft October 30, 2024 20:48
@stacimc stacimc marked this pull request as ready for review October 30, 2024 21:13
@krysal
Copy link
Member

krysal commented Oct 31, 2024

@stacimc I can see the passed param in the Code tab of the task, but I can't find where the exact pook_interval value the task gets. This looks good as it passes an independent value onto each process. Do we also need new variables for each one? Currently, both are using the same:

reindex_poke_interval=int(os.getenv("DATA_REFRESH_POKE_INTERVAL", 60)),

reindex_poke_interval=int(os.getenv("DATA_REFRESH_POKE_INTERVAL", 60)),

@stacimc
Copy link
Collaborator Author

stacimc commented Oct 31, 2024

Thanks for catching that, @krysal -- yes, I think those poke intervals should be updated. I've adjusted:

  • image
    • concurrency check interval to every 5 minutes (we should not poll more often than this to avoid overloading the scheduler)
    • reindex interval to every 10 minutes (as the image indexing is comparatively long)
  • audio
    • concurrency to every 30 minutes; if the audio data refresh is stuck waiting on the image data refresh, it should poll less frequently due to the long-running nature of that DAG
    • reindex interval to every 5 minutes for the comparatively short audio reindex

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stacimc stacimc merged commit 452558a into main Oct 31, 2024
46 checks passed
@stacimc stacimc deleted the update/data-refresh-poke-interval-per-env branch October 31, 2024 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants