Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually set option's selected prop #5118

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Oct 31, 2024

Fixes

Fixes #5117 by @obulat

Description

This PR adds selected to the individual option that is selected to make the correct option selected in SSR. This prevents a change after the page is loaded.

Testing Instructions

Go to the homepage and check that the correct option is selected when the page renders initially, not after the page is mounted.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner October 31, 2024 04:34
@obulat obulat requested review from krysal and dhruvkb October 31, 2024 04:34
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Oct 31, 2024
@obulat obulat force-pushed the fix/selected-option-in-ssr branch from a650c49 to 9d791a1 Compare October 31, 2024 04:36
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  8.8 MB/s
     data_sent......................: 838 kB  5.0 kB/s
     http_req_blocked...............: avg=9.5µs    min=2.02µs   med=3.67µs   max=4.05ms  p(90)=5.19µs   p(95)=5.68µs  
     http_req_connecting............: avg=5.27µs   min=0s       med=0s       max=4ms     p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=586.18ms min=39.77ms  med=511.66ms max=2.21s   p(90)=1.06s    p(95)=1.16s   
       { expected_response:true }...: avg=586.18ms min=39.77ms  med=511.66ms max=2.21s   p(90)=1.06s    p(95)=1.16s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=136.44µs min=40.09µs  med=109.02µs max=14.68ms p(90)=172.89µs p(95)=212.78µs
     http_req_sending...............: avg=20.26µs  min=6.93µs   med=18.7µs   max=3.31ms  p(90)=24.48µs  p(95)=26.71µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=586.02ms min=39.61ms  med=511.48ms max=2.21s   p(90)=1.06s    p(95)=1.16s   
     http_reqs......................: 6400    37.885005/s
     iteration_duration.............: avg=3.13s    min=630.13ms med=2.64s    max=9.38s   p(90)=6.09s    p(95)=6.43s   
     iterations.....................: 1200    7.103438/s
     vus............................: 1       min=1       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat merged commit 66583ed into main Oct 31, 2024
46 checks passed
@obulat obulat deleted the fix/selected-option-in-ssr branch October 31, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Selects don't render selected option on the server
3 participants