Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit to 2 alter_data_batches concurrently #5125

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

stacimc
Copy link
Collaborator

@stacimc stacimc commented Oct 31, 2024

Fixes

Description

No limit was put on the number of alter_data batches run concurrently during the data refresh, causing Airflow to be overloaded during an image data refresh. This PR updates the DAG to allow a max of 2 concurrent alter_data batches. We can evaluate later if this can be increased (or even if it should be decreased to 1).

Testing Instructions

Run the staging_image_data_refresh DAG locally. Watch the alter_batches[] step and observe that no more than 2 tasks are put into the running state at a time.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@stacimc stacimc added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Oct 31, 2024
@stacimc stacimc self-assigned this Oct 31, 2024
@stacimc stacimc requested a review from a team as a code owner October 31, 2024 20:22
@stacimc stacimc requested review from krysal and obulat and removed request for a team October 31, 2024 20:22
@stacimc stacimc merged commit 071e422 into main Oct 31, 2024
71 checks passed
@stacimc stacimc deleted the fix/set-max-active-tis-on-alter-data branch October 31, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Status: No status
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants