Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use healthcheck command preferred by MinIO #5170

Merged
merged 2 commits into from
Nov 18, 2024
Merged

Use healthcheck command preferred by MinIO #5170

merged 2 commits into from
Nov 18, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 18, 2024

Description

This PR updates the healthcheck used by the MinIO container to mc which is the preferred healthcheck tool.

Testing Instructions

  1. Check out the PR.
  2. Start the catalog containers with just catalog/up.
  3. Wait for a few seconds.
  4. Run just dc ps to see the status of the Docker Compose services.
  5. The MinIO service s3 should show the status as healthy.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: catalog Related to the catalog and Airflow DAGs labels Nov 18, 2024
@dhruvkb dhruvkb requested review from a team as code owners November 18, 2024 10:27
@dhruvkb dhruvkb requested review from krysal and obulat and removed request for a team November 18, 2024 10:27
@dhruvkb dhruvkb changed the title Use Minio's preferred healthcheck Use healthcheck command preferred by MinIO Nov 18, 2024
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you find this change?

Worked well locally, first log from docker ps: Up 15 seconds (health: starting), second log: Up 39 seconds (healthy)

docker/minio/env.template Outdated Show resolved Hide resolved
@dhruvkb
Copy link
Member Author

dhruvkb commented Nov 18, 2024

I was trying to understand MinIO better and was casually reading their docs and GitHub issues. There I came across a discussion that healthchecks were failing because curl couldn't be found. In that it was recommended to use mc.

@dhruvkb dhruvkb merged commit 392219c into main Nov 18, 2024
44 checks passed
@dhruvkb dhruvkb deleted the minio_hc branch November 18, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: catalog Related to the catalog and Airflow DAGs
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants