Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle case when the input template ref is falsy in the mobile header #5193

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 28, 2024

Fixes

Fixes #5190 by @obulat

Description

This PR checks if the search input template ref value is not null before focusing it or setting the selection. I'm not sure when this value can be null, but Sentry does show that this can happen.

This PR also replaces the template refs in VMobileHeader with the new useTemplateRef helper.

Testing Instructions

The CI should pass

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 416      ✗ 0   
     data_received..................: 95 MB   393 kB/s
     data_sent......................: 54 kB   225 B/s
     http_req_blocked...............: avg=39.94µs  min=2.5µs    med=4.89µs   max=1.27ms p(90)=153.43µs p(95)=182.75µs
     http_req_connecting............: avg=27.33µs  min=0s       med=0s       max=1.21ms p(90)=103.44µs p(95)=131.31µs
     http_req_duration..............: avg=209.04ms min=30.44ms  med=162.18ms max=1.38s  p(90)=418.44ms p(95)=461.45ms
       { expected_response:true }...: avg=209.04ms min=30.44ms  med=162.18ms max=1.38s  p(90)=418.44ms p(95)=461.45ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 416 
     http_req_receiving.............: avg=189.3µs  min=67.1µs   med=133.57µs max=6.39ms p(90)=285.59µs p(95)=324.65µs
     http_req_sending...............: avg=43.73µs  min=6.48µs   med=22.98µs  max=3.95ms p(90)=37.82µs  p(95)=44.33µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s     p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=208.81ms min=30.34ms  med=162.03ms max=1.38s  p(90)=418.1ms  p(95)=461.14ms
     http_reqs......................: 416     1.723255/s
     iteration_duration.............: avg=1.12s    min=605.15ms med=1.26s    max=2.47s  p(90)=1.45s    p(95)=1.87s   
     iterations.....................: 78      0.32311/s
     vus............................: 4       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat force-pushed the fix/input-null-check branch from 7091bfb to d403a51 Compare November 28, 2024 14:17
@obulat obulat marked this pull request as ready for review November 28, 2024 15:07
@obulat obulat requested a review from a team as a code owner November 28, 2024 15:07
@obulat obulat requested review from krysal and dhruvkb November 28, 2024 15:07
@obulat obulat force-pushed the fix/input-null-check branch from d403a51 to 61efd4f Compare November 29, 2024 03:41
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@obulat obulat force-pushed the fix/input-null-check branch from 61efd4f to 608fcfc Compare December 4, 2024 05:54
@obulat obulat merged commit 31a1c9b into main Dec 4, 2024
46 checks passed
@obulat obulat deleted the fix/input-null-check branch December 4, 2024 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

TypeError: Cannot read properties of null (reading 'value') - in VHeaderMobile
3 participants