Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the CI by fixing the i18n dependencies, and updating vite to v6.0.1 #5198

Merged
merged 2 commits into from
Nov 28, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 28, 2024

Fixes

Fixes #5197 by @obulat

Description

The most recent version of i18n/shared package added create function:

https://github.com/intlify/vue-i18n/blob/0bd4e68b84d163302819dd21ef4d5fcb6b989f3a/packages/shared/src/utils.ts#L85

In the CI in Playwright, one of the i18n packages was updated to 10.0.5 version, while other dependent packages stayed on 10.0.4, so the imported create function wasn't found. I'm not sure why that only happened in the CI, but didn't happen for me locally.

Originally, I thought that the problem was with the mismatch of vite versions, so it is updated to the latest version here, too. It should be compatible with the other dependencies.

Testing Instructions

The CI should pass.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Nov 28, 2024
Copy link

github-actions bot commented Nov 28, 2024

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400     ✗ 0   
     data_received..................: 1.5 GB  7.7 MB/s
     data_sent......................: 837 kB  4.3 kB/s
     http_req_blocked...............: avg=11.68µs  min=1.88µs  med=4.09µs   max=8.26ms  p(90)=5.67µs   p(95)=6.17µs  
     http_req_connecting............: avg=7.22µs   min=0s      med=0s       max=8.22ms  p(90)=0s       p(95)=0s      
     http_req_duration..............: avg=670.97ms min=35.63ms med=593.15ms max=2.48s   p(90)=1.18s    p(95)=1.28s   
       { expected_response:true }...: avg=670.97ms min=35.63ms med=593.15ms max=2.48s   p(90)=1.18s    p(95)=1.28s   
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 6400
     http_req_receiving.............: avg=145.22µs min=39.91µs med=121.9µs  max=15.47ms p(90)=191.43µs p(95)=227.54µs
     http_req_sending...............: avg=23.09µs  min=5.38µs  med=19.91µs  max=7.92ms  p(90)=26µs     p(95)=28.54µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=670.8ms  min=35.44ms med=592.98ms max=2.48s   p(90)=1.18s    p(95)=1.28s   
     http_reqs......................: 6400    32.83237/s
     iteration_duration.............: avg=3.58s    min=1.25s   med=3.08s    max=9.49s   p(90)=6.88s    p(95)=7.21s   
     iterations.....................: 1200    6.156069/s
     vus............................: 3       min=3      max=30
     vus_max........................: 30      min=30     max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat changed the title Update vite to v6.0.1 Fix the CI by fixing the i18n dependencies, and updating vite to v6.0.1 Nov 28, 2024
@obulat obulat self-assigned this Nov 28, 2024
@obulat obulat marked this pull request as ready for review November 28, 2024 12:35
@obulat obulat requested a review from a team as a code owner November 28, 2024 12:35
@obulat obulat requested review from krysal and dhruvkb November 28, 2024 12:35
@obulat obulat merged commit decc584 into main Nov 28, 2024
57 checks passed
@obulat obulat deleted the update/vite branch November 28, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Newest version of vite in Playwright container causes the build to fail
3 participants