Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a memory leak to check k6 tests #5213

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Introduce a memory leak to check k6 tests #5213

merged 1 commit into from
Nov 29, 2024

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Nov 29, 2024

Fixes

Related to #5179 by @obulat

Description

Revert "Fix frontend memory leak (#4864)" - to see how a memory leak affects the CPU and memory values under load test

This reverts commit a5d966d

This commit will be reverted after the k6 load testing checks are done

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Revert "Fix frontend memory leak (#4864)"
This reverts commit a5d966d
@obulat obulat requested a review from a team as a code owner November 29, 2024 05:03
@obulat obulat requested review from krysal and dhruvkb November 29, 2024 05:03
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 29, 2024
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Nov 29, 2024
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 6400      ✗ 0   
     data_received..................: 1.5 GB  7.9 MB/s
     data_sent......................: 837 kB  4.5 kB/s
     http_req_blocked...............: avg=12.24µs  min=1.97µs  med=4µs      max=8.87ms  p(90)=5.67µs p(95)=6.11µs  
     http_req_connecting............: avg=6.87µs   min=0s      med=0s       max=8.83ms  p(90)=0s     p(95)=0s      
     http_req_duration..............: avg=654.36ms min=28.37ms med=569.07ms max=2.46s   p(90)=1.18s  p(95)=1.27s   
       { expected_response:true }...: avg=654.36ms min=28.37ms med=569.07ms max=2.46s   p(90)=1.18s  p(95)=1.27s   
   ✓ http_req_failed................: 0.00%   ✓ 0         ✗ 6400
     http_req_receiving.............: avg=174.55µs min=36.16µs med=116.84µs max=41.48ms p(90)=185µs  p(95)=221.06µs
     http_req_sending...............: avg=21.34µs  min=5.95µs  med=19.3µs   max=1.98ms  p(90)=25.3µs p(95)=27.43µs 
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s     p(95)=0s      
     http_req_waiting...............: avg=654.17ms min=28.21ms med=568.81ms max=2.46s   p(90)=1.18s  p(95)=1.27s   
     http_reqs......................: 6400    34.060096/s
     iteration_duration.............: avg=3.49s    min=1.1s    med=2.98s    max=8.61s   p(90)=6.85s  p(95)=7.12s   
     iterations.....................: 1200    6.386268/s
     vus............................: 1       min=1       max=30
     vus_max........................: 30      min=30      max=30

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat obulat merged commit 95fd407 into main Nov 29, 2024
73 of 83 checks passed
@obulat obulat deleted the add/memory-leak branch November 29, 2024 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟧 priority: high Stalls work on the project or its dependents 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants