Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track focus event instead of click to support Safari #5216

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 29, 2024

Fixes

Fixes #5215 by @fcoveram

Description

This PR changes the theme selector to listen on the focus event on the <select> field instead of click so that bug in Safari can be mitigated.

Testing Instructions

  1. Verify that the bug cannot be reproduced in Safari.
  2. Verify that the behaviour in other browsers like Firefox and Chrome hasn't changed.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb requested a review from a team as a code owner November 29, 2024 12:07
@dhruvkb dhruvkb requested review from krysal and obulat November 29, 2024 12:07
@openverse-bot openverse-bot added 🧱 stack: frontend Related to the Nuxt frontend 🟩 priority: low Low priority and doesn't need to be rushed 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Nov 29, 2024
Copy link

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 414      ✗ 0   
     data_received..................: 97 MB   401 kB/s
     data_sent......................: 54 kB   224 B/s
     http_req_blocked...............: avg=72µs     min=2.39µs   med=4.78µs   max=1.28ms   p(90)=137.96µs p(95)=612.71µs
     http_req_connecting............: avg=53.38µs  min=0s       med=0s       max=1.23ms   p(90)=96.28µs  p(95)=174.93µs
     http_req_duration..............: avg=194.74ms min=30.93ms  med=153.77ms max=715.77ms p(90)=378.69ms p(95)=431.24ms
       { expected_response:true }...: avg=194.74ms min=30.93ms  med=153.77ms max=715.77ms p(90)=378.69ms p(95)=431.24ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 414 
     http_req_receiving.............: avg=165.99µs min=46.98µs  med=142.01µs max=628.21µs p(90)=275.95µs p(95)=324.65µs
     http_req_sending...............: avg=27.29µs  min=9.44µs   med=22.04µs  max=129.36µs p(90)=43.45µs  p(95)=74.62µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=194.54ms min=30.78ms  med=153.61ms max=715.3ms  p(90)=378.2ms  p(95)=430.91ms
     http_reqs......................: 414     1.716084/s
     iteration_duration.............: avg=1.05s    min=550.91ms med=1.2s     max=2.02s    p(90)=1.37s    p(95)=1.4s    
     iterations.....................: 77      0.319175/s
     vus............................: 3       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and simple fix!

@dhruvkb dhruvkb merged commit 7360355 into main Dec 4, 2024
69 of 73 checks passed
@dhruvkb dhruvkb deleted the safari_set_seen branch December 4, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Theme selector with previous dark theme colors
3 participants