Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable debugging of the API server from inside a Docker container #5218

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Nov 30, 2024

Description

This PR enable the API to be debugged from VS Code.

This PR

  • adds a debugpy dev package to the API.
  • adds commands and port mappings to run and connect to the debugpy server from outside the container.
  • adds documentation for setting up VS Code to connect to this server and start debugging.

Testing Instructions

  1. Check out the PR and follow the added documentation.
  2. Verify that following the steps leads to a functional debugging setup.

Checklist

  • My pull request has a descriptive title (not a vague title likeUpdate index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.
  • I ran the DAG documentation generator (ov just catalog/generate-docs for catalog
    PRs) or the media properties generator (ov just catalog/generate-docs media-props
    for the catalog or ov just api/generate-docs for the API) where applicable.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase 🧱 stack: api Related to the Django API 🧱 stack: documentation Related to Sphinx documentation labels Nov 30, 2024
@dhruvkb dhruvkb requested review from a team as code owners November 30, 2024 07:04
@dhruvkb dhruvkb requested review from krysal and obulat and removed request for a team November 30, 2024 07:04
Copy link

github-actions bot commented Nov 30, 2024

Full-stack documentation: https://docs.openverse.org/_preview/5218

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

New files ➕:

Changed files 🔄:

@dhruvkb dhruvkb changed the title Install debugpy package Enable debugging of the API server from inside a Docker container Nov 30, 2024
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing! This will make debugging much easier. I can event see several ThreadPoolExecutors running :)

Hope this will soon be available in PyCharm, too.

api/compose.yml Outdated Show resolved Hide resolved
documentation/api/guides/debugging.md Outdated Show resolved Hide resolved
Co-authored-by: Olga Bulat <obulat@gmail.com>
@dhruvkb dhruvkb merged commit 4a67722 into main Dec 4, 2024
48 checks passed
@dhruvkb dhruvkb deleted the add_debugpy_api branch December 4, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: api Related to the Django API 🧱 stack: documentation Related to Sphinx documentation
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants