Update the icon color in onMounted
#5237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #5227 by @obulat
Description
This PR replaces the
computed
values for icon names withref
that are updated inonMounted
(which runs after the hydration is done). The license icons and the theme icons are affected, but I can revert the change for the theme switcher if #5236 is the preferred approach, @dhruvkb .Testing Instructions
Select the "system" mode and refresh a single result page. Make sure your system is set to dark mode by default (or use the browser devtools). Refresh the page and see that there are no client-server mismatch warnings: neither for the theme switcher (sun/moon icons) nor for the license icons on every image result:
Checklist
Update index.md
).main
) or a parent feature branch.ov just catalog/generate-docs
for catalogPRs) or the media properties generator (
ov just catalog/generate-docs media-props
for the catalog or
ov just api/generate-docs
for the API) where applicable.Developer Certificate of Origin
Developer Certificate of Origin