Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ov in CI + CD #5262

Closed
wants to merge 9 commits into from
Closed

Use ov in CI + CD #5262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
e4d1ecf
Use ov in CI + CD
dhruvkb Dec 10, 2024
4e71aac
Ensure NPM cache exists and has mode 777
dhruvkb Dec 10, 2024
ff81b36
Move npm cache to a temp directory
dhruvkb Dec 10, 2024
65d314a
Run ov as root in CI
dhruvkb Dec 10, 2024
9a560ef
Do not set user in CI
dhruvkb Dec 10, 2024
b2df8c7
Revert changes
dhruvkb Dec 11, 2024
0319ce1
Remove redundant 'precommit' step
dhruvkb Dec 11, 2024
b82b381
Bust npm cache before attempting to lint
dhruvkb Dec 11, 2024
7e6f5d8
Use `sudo` when removing files owned by root
dhruvkb Dec 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/actions/setup-env/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,13 @@ inputs:
runs:
using: "composite"
steps:
# Setup dev-env
- name: Setup ov
shell: bash
run: |
./ov build
./ov setup-env
Comment on lines +28 to +29
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have thought this would need to include a call to ov just install as well; or is the plan to install specifically for each CI step? If the whole ov container and volume is going to be cached between jobs then installing once at the start would save some time on subsequent jobs 🤔. I don't know if the volume will work that way, though.


# Just
- name: Setup just
uses: taiki-e/install-action@v2
Expand Down
19 changes: 7 additions & 12 deletions .github/workflows/ci_cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,23 +109,18 @@ jobs:
- name: Setup CI env
uses: ./.github/actions/setup-env
with:
# PDM is needed to run Vale
setup_python: "true"
# Node.js is needed by lint actions.
install_recipe: "node-install"

- name: Cache pre-commit envs
uses: actions/cache@v4
with:
path: ~/.cache/pre-commit
key: ${{ runner.os }}-pre-commit-${{ hashFiles('.pre-commit-config.yaml') }}
setup_python: false
# Python is not needed to run lint.
setup_nodejs: false
# Node.js is not needed to run lint.
install_recipe: ""

- name: Run pre-commit to lint files
env:
GITHUB_TOKEN: ${{ github.token }}
run: |
just precommit
just lint
./ov sudo rm -rf /opt/.npm
./ov just lint

validate-codeowners:
name: Validate CODEOWNERS
Expand Down
Loading