Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only show audio message when track ID matches active #5305

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
+30 −1
Open

fix: only show audio message when track ID matches active #5305

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
411fa85
fix: only show audio message when track ID matches active
Anuj012004 Dec 31, 2024
68499ac
fix: only show audio messages on active track
Anuj012004 Jan 1, 2025
df4c9e4
fix:match audio track id before displaying messages
Anuj012004 Jan 1, 2025
74ecdd4
Merge branch 'main' into fix/audio-error-content-view
Anuj012004 Jan 1, 2025
41b2233
test: add audio message display test cases
Anuj012004 Jan 2, 2025
556f697
Merge branch 'fix/audio-error-content-view' of https://github.com/Anu…
Anuj012004 Jan 2, 2025
2b0d246
Merge branch 'main' into fix/audio-error-content-view
Anuj012004 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/src/components/VAudioTrack/VAudioTrack.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ watch(
/* Timekeeping */

const message = computed(() =>
activeMediaStore.message
activeMediaStore.id === props.audio.id && activeMediaStore.message
? t(`audioTrack.messages.${activeMediaStore.message}`)
: ""
)
Expand Down
29 changes: 29 additions & 0 deletions frontend/test/unit/specs/components/AudioTrack/v-audio-track.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,4 +158,33 @@ describe("AudioTrack", () => {
expect(screen.queryAllByTitle(match)).toEqual([])
expect(screen.queryAllByAltText(match)).toEqual([])
})

it("should show message when audio ID matches active ID", async () => {
const activeMediaStore = useActiveMediaStore()
const audioId = props.audio.id
activeMediaStore.$patch({
state: {
id: audioId,
message: "playing",
type: "audio"
}
})

const { getByText } = await render(VAudioTrack, options)
expect(getByText(/playing/i)).toBeVisible()
})

it("should not show message when audio ID doesn't match active ID", async () => {
const activeMediaStore = useActiveMediaStore()
activeMediaStore.$patch({
state: {
id: "different-id",
message: "playing",
type: "audio"
}
})

const { queryByText } = await render(VAudioTrack, options)
expect(queryByText(/playing/i)).not.toBeInTheDocument()
})
})
Loading