Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency node-html-parser to v7 #5318

Merged
merged 2 commits into from
Jan 6, 2025

Conversation

openverse-bot
Copy link
Collaborator

@openverse-bot openverse-bot commented Jan 6, 2025

This PR contains the following updates:

Package Type Update Change
node-html-parser devDependencies major ^6.1.13 -> ^7.0.0

Release Notes

taoqf/node-fast-html-parser (node-html-parser)

v7.0.1

Compare Source


Configuration

📅 Schedule: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@openverse-bot openverse-bot requested a review from a team as a code owner January 6, 2025 13:12
@openverse-bot openverse-bot added dependencies Pull requests that update a dependency file 💻 aspect: code Concerns the software code in the repository 🟨 tech: javascript Involves JavaScript 🟩 priority: low Low priority and doesn't need to be rushed 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🧱 stack: frontend Related to the Nuxt frontend labels Jan 6, 2025
@openverse-bot openverse-bot requested review from krysal and obulat January 6, 2025 13:12
Copy link

github-actions bot commented Jan 6, 2025

Latest k6 run output1

     ✓ status was 200

     checks.........................: 100.00% ✓ 404      ✗ 0   
     data_received..................: 93 MB   387 kB/s
     data_sent......................: 53 kB   220 B/s
     http_req_blocked...............: avg=39.68µs  min=2.24µs   med=4.38µs   max=2.17ms  p(90)=144.77µs p(95)=166.46µs
     http_req_connecting............: avg=27µs     min=0s       med=0s       max=2.11ms  p(90)=99.09µs  p(95)=117.23µs
     http_req_duration..............: avg=159.7ms  min=16.96ms  med=115.77ms max=1.04s   p(90)=337.13ms p(95)=421.79ms
       { expected_response:true }...: avg=159.7ms  min=16.96ms  med=115.77ms max=1.04s   p(90)=337.13ms p(95)=421.79ms
   ✓ http_req_failed................: 0.00%   ✓ 0        ✗ 404 
     http_req_receiving.............: avg=162.7µs  min=60.65µs  med=137.66µs max=723.4µs p(90)=279.43µs p(95)=329.51µs
     http_req_sending...............: avg=24.26µs  min=8.08µs   med=22.87µs  max=66.28µs p(90)=36.14µs  p(95)=42.38µs 
     http_req_tls_handshaking.......: avg=0s       min=0s       med=0s       max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting...............: avg=159.52ms min=16.86ms  med=115.48ms max=1.03s   p(90)=336.95ms p(95)=421.46ms
     http_reqs......................: 404     1.677301/s
     iteration_duration.............: avg=844.62ms min=370.15ms med=931.5ms  max=1.7s    p(90)=1.12s    p(95)=1.49s   
     iterations.....................: 77      0.319684/s
     vus............................: 2       min=0      max=6 
     vus_max........................: 60      min=60     max=60

Footnotes

  1. This comment will automatically update with new output each time k6 runs for this PR

@obulat
Copy link
Contributor

obulat commented Jan 6, 2025

This package was used to parse the GlotPress translations page to extract the translated percentage. With recent changes, the translated percentage is now calculated based on the translation files, so we no longer need this package. I will update this PR to remove the dependency instead.

@openverse-bot openverse-bot force-pushed the gha-renovatenode-html-parser-7.x branch from 3ed29eb to f9b0686 Compare January 6, 2025 16:40
@obulat obulat changed the title Update dependency node-html-parser to v7 Remove dependency node-html-parser to v7 Jan 6, 2025
@obulat obulat force-pushed the gha-renovatenode-html-parser-7.x branch from 39df7e1 to 74d5004 Compare January 6, 2025 17:23
@obulat obulat merged commit 8c983ab into main Jan 6, 2025
48 checks passed
@obulat obulat deleted the gha-renovatenode-html-parser-7.x branch January 6, 2025 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💻 aspect: code Concerns the software code in the repository dependencies Pull requests that update a dependency file 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed 🧱 stack: frontend Related to the Nuxt frontend 🟨 tech: javascript Involves JavaScript
Projects
Status: 🤝 Merged
Development

Successfully merging this pull request may close these issues.

2 participants