Enhance error message extraction and move class to more appropriate namespace #145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
JasonTheAdams
approved these changes
Dec 8, 2025
Member
JasonTheAdams
left a comment
JasonTheAdams
left a comment
There was a problem hiding this comment.
Small suggestion, but otherwise looks good!
Comment on lines
+38
to
+45
| if ( | ||
| isset($data[0]) && | ||
| is_array($data[0]) && | ||
| isset($data[0]['error']) && | ||
| is_array($data[0]['error']) && | ||
| isset($data[0]['error']['message']) && | ||
| is_string($data[0]['error']['message']) | ||
| ) { |
Member
There was a problem hiding this comment.
You don't need to check each layer. PHP supports checking multiple layers down. 👍
Suggested change
| if ( | |
| isset($data[0]) && | |
| is_array($data[0]) && | |
| isset($data[0]['error']) && | |
| is_array($data[0]['error']) && | |
| isset($data[0]['error']['message']) && | |
| is_string($data[0]['error']['message']) | |
| ) { | |
| if (isset($data[0]['error']['message']) && is_string($data[0]['error']['message'])) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some provider API endpoints, such as those from Google may return an array of error objects with message inside. This PR enhances the
ErrorMessageExtractorto account for that shape, leading to more helpful error messages.Additionally, I noticed there's both a
Providers\Http\Utilnamespace and aProviders\Http\Utilitiesnamespace. That doesn't make any sense, so they are being combined into one as part of this PR.