Skip to content

Conversation

@davidperezgar
Copy link
Member

Fixes #464

@davidperezgar davidperezgar linked an issue Sep 29, 2024 that may be closed by this pull request
@github-actions
Copy link

github-actions bot commented Sep 29, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>
Co-authored-by: dd32 <dd32@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@davidperezgar davidperezgar requested review from swissspidy and removed request for barrykooij and frantorres September 29, 2024 10:03
@davidperezgar davidperezgar changed the title Fixes Tradermarks check with acronym allowed Added Tradermarks check with acronym allowed Sep 29, 2024
@ernilambar ernilambar changed the title Added Tradermarks check with acronym allowed Added Trademarks check with acronym allowed Sep 30, 2024
Co-authored-by: Nilambar Sharma <ernilambar@users.noreply.github.com>
@davidperezgar davidperezgar requested a review from dd32 October 1, 2024 08:23
@davidperezgar
Copy link
Member Author

There were changes in WordPress Foundation Trademark's, and we have to cover in this PR.

davidperezgar and others added 3 commits October 1, 2024 10:41
Co-authored-by: Pascal Birchler <pascalb@google.com>
Co-authored-by: Pascal Birchler <pascalb@google.com>
Co-authored-by: Pascal Birchler <pascalb@google.com>
Co-authored-by: Pascal Birchler <pascalb@google.com>
@swissspidy swissspidy added this to the 1.2.0 milestone Oct 1, 2024
@davidperezgar
Copy link
Member Author

Please don't merge yet as we need to clarify to the Foundation the trademark changes.

@davidperezgar
Copy link
Member Author

Result of conversations:

The current status-quo of not allowing wp- in slugs is fine, no need to change that, but if they use it in their plugin name that’s fine.

@davidperezgar davidperezgar removed this from the 1.2.0 milestone Oct 10, 2024
@swissspidy swissspidy added this to the 1.3.0 milestone Oct 11, 2024
@ernilambar ernilambar removed this from the 1.3.0 milestone Oct 29, 2024
@davidperezgar davidperezgar added the Needs Discussion Anything that needs a discussion/agreement label Nov 3, 2024
@davidperezgar
Copy link
Member Author

After our Plugin Review Meeting, we were agreed that this PR can be published. Please review and accept it!

Co-authored-by: Nilambar Sharma <ernilambar@users.noreply.github.com>
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 13, 2024
@ernilambar ernilambar added [Team] Plugins Issues owned by Plugins Team and removed Needs Discussion Anything that needs a discussion/agreement labels Nov 14, 2024
@ernilambar ernilambar merged commit 608225a into trunk Nov 14, 2024
@ernilambar ernilambar deleted the 464-allow-wp-prefixes-on-plugins branch November 14, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Team] Plugins Issues owned by Plugins Team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow wp- prefixes on plugins

5 participants