Skip to content

Conversation

@ernilambar
Copy link
Member

@ernilambar ernilambar commented Nov 12, 2024

Fixes #756

  • Introduce new sniff: PluginCheck.CodeAnalysis.RequiredFunctionParameters
  • Add this rule to plugin-review.xml
  • Add unit test for the changes

@ernilambar ernilambar marked this pull request as ready for review November 12, 2024 10:56
@github-actions
Copy link

github-actions bot commented Nov 12, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ernilambar <rabmalin@git.wordpress.org>
Co-authored-by: davidperezgar <davidperez@git.wordpress.org>
Co-authored-by: frantorres <frantorres@git.wordpress.org>
Co-authored-by: swissspidy <swissspidy@git.wordpress.org>
Co-authored-by: chriscct7 <chriscct7@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ernilambar ernilambar added [Type] Enhancement A suggestion for improvement of an existing feature [Team] Plugins Issues owned by Plugins Team labels Nov 12, 2024
@ernilambar ernilambar added this to the 1.3.0 milestone Nov 13, 2024
@ernilambar ernilambar force-pushed the 756-required-functions-param branch from f201b8c to 5bc1d81 Compare November 19, 2024 05:22
@ernilambar ernilambar force-pushed the 756-required-functions-param branch from 2b24bc4 to f8ac867 Compare November 24, 2024 15:47
@ernilambar ernilambar merged commit 27b111b into trunk Nov 26, 2024
23 checks passed
@ernilambar ernilambar deleted the 756-required-functions-param branch November 26, 2024 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Team] Plugins Issues owned by Plugins Team [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Restrict parse_str() without second argument

4 participants