Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action: Add phpcs checks #17

Merged
merged 7 commits into from
Dec 18, 2024
Merged

Github Action: Add phpcs checks #17

merged 7 commits into from
Dec 18, 2024

Conversation

kraftbj
Copy link
Collaborator

@kraftbj kraftbj commented Dec 18, 2024

Initial run at adding basic phpcs checks via GitHub Actions and Husky pre-commit hooks.

Testing: Create a PR into this branch with a PHP change. One change should be adding new code without error. One should be adding new code with an error. Another should be adding new code on a line with an existing error.

Test PR: kraftbj/secure-custom-fields#1

Copy link

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a quick once-over.

.github/workflows/phpcs.yml Outdated Show resolved Hide resolved
.husky/pre-commit-phpcbf.sh Outdated Show resolved Hide resolved
.husky/pre-commit-phpcbf.sh Show resolved Hide resolved
.husky/pre-commit-phpcbf.sh Outdated Show resolved Hide resolved
.husky/pre-commit-phpcbf.sh Outdated Show resolved Hide resolved
Copy link

@anomiex anomiex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@kraftbj kraftbj merged commit 1c6c0d4 into trunk Dec 18, 2024
1 check passed
@kraftbj kraftbj deleted the add/phpcs-checks branch December 18, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants