Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump the minimum required version of Node.js to 20.x #5515

Closed
wants to merge 21 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
a7c5b0e
Bump the minimum required version of Node.js and npm.
desrosj Oct 17, 2023
1382aa4
Merge remote-tracking branch 'upstream/trunk' into update/nodejs-20
desrosj Nov 13, 2023
ecf47f7
Eliminate duplicate CSS rule.
desrosj Nov 13, 2023
2543955
Merge remote-tracking branch 'upstream/trunk' into update/nodejs-20
desrosj Nov 14, 2023
e0af00f
Merge branch 'trunk' of https://github.com/WordPress/wordpress-develo…
desrosj Nov 17, 2023
71c26f7
Merge remote-tracking branch 'upstream/trunk' into update/nodejs-20
desrosj Nov 20, 2023
db1be3e
Add `engine` definition to default themes.
desrosj Nov 20, 2023
e6437cd
Test Node.js 18 and 20.
desrosj Nov 20, 2023
9c3c7f3
Add Node.js version to Gutenberg testing.
desrosj Nov 20, 2023
442cb69
Test against PR branch.
desrosj Nov 20, 2023
725db11
Add Node.JS version to job name.
desrosj Nov 20, 2023
d0376ef
Update to Node.js 20.
desrosj Dec 5, 2023
495982d
Use the `trunk` version of the build workflow.
desrosj Dec 5, 2023
b8ae40a
Check the desired version of Node is being used.
desrosj Dec 6, 2023
f8f31e6
Use the `setup-node` action instead of `nvm`.
desrosj Dec 6, 2023
0186507
Change Node version back after resetting.
desrosj Dec 6, 2023
7caaa38
Merge remote-tracking branch 'upstream/trunk' into update/nodejs-20
desrosj Dec 7, 2023
c7b38d9
Merge remote-tracking branch 'upstream/trunk' into update/nodejs-20
desrosj Dec 18, 2023
506e68d
Merge branch 'trunk' into update/nodejs-20
desrosj Dec 19, 2023
f326358
Merge remote-tracking branch 'upstream/trunk' into update/nodejs-20
desrosj Dec 20, 2023
b6c9f1c
Add `check-latest` to ensure the needed version is installed.
desrosj Dec 20, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/callable-test-core-build-process.yml
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ jobs:
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
with:
node-version-file: '.nvmrc'
check-latest: true
cache: npm

- name: Log debug information
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ jobs:
uses: actions/setup-node@8f152de45cc393bb48ce5d89d36b731f54556e65 # v4.0.0
with:
node-version-file: '.nvmrc'
check-latest: true
cache: npm
cache-dependency-path: |
package-lock.json
Expand Down
14 changes: 14 additions & 0 deletions .github/workflows/performance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,12 +71,14 @@ jobs:
# - Run performance tests (current commit).
# - Print performance tests results.
# - Check out target commit (target branch or previous commit).
# - Switch Node.js versions if necessary.
# - Install npm dependencies.
# - Build WordPress.
# - Run any database upgrades.
# - Run performance tests (previous/target commit).
# - Print target performance tests results.
# - Reset to original commit.
# - Switch Node.js versions if necessary.
# - Install npm dependencies.
# - Set the environment to the baseline version.
# - Run any database upgrades.
Expand Down Expand Up @@ -190,6 +192,12 @@ jobs:
fi
git reset --hard $TARGET_SHA

- name: Set up Node.js
desrosj marked this conversation as resolved.
Show resolved Hide resolved
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: '.nvmrc'
cache: npm

- name: Install npm dependencies
run: npm ci

Expand All @@ -212,6 +220,12 @@ jobs:
- name: Reset to original commit
run: git reset --hard $GITHUB_SHA

- name: Set up Node.js
uses: actions/setup-node@5e21ff4d9bc1a8cf6de233a3057d20ec6b3fb69d # v3.8.1
with:
node-version-file: '.nvmrc'
cache: npm

- name: Install npm dependencies
run: npm ci

Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@
"url": "https://develop.svn.wordpress.org/trunk"
},
"engines": {
"node": ">=16.19.1",
"npm": ">=8.19.3 <9"
"node": ">=20.10.0",
"npm": ">=10.2.3"
},
"author": "The WordPress Contributors",
"license": "GPL-2.0-or-later",
Expand Down
110 changes: 57 additions & 53 deletions src/wp-content/themes/twentynineteen/package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 8 additions & 4 deletions src/wp-content/themes/twentynineteen/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,20 @@
"url": "https://core.trac.wordpress.org/"
},
"homepage": "https://wordpress.org/themes/twentynineteen/",
"engines": {
"node": ">=20.10.0",
"npm": ">=10.2.3"
},
"devDependencies": {
"@wordpress/browserslist-config": "^5.24.0",
"autoprefixer": "^10.4.15",
"@wordpress/browserslist-config": "^5.30.0",
"autoprefixer": "^10.4.16",
"chokidar-cli": "^3.0.0",
"node-sass": "^9.0.0",
"npm-run-all": "^4.1.5",
"postcss": "^8.4.29",
"postcss": "^8.4.32",
"postcss-cli": "^10.1.0",
"postcss-focus-within": "^8.0.0",
"rtlcss": "^4.1.0"
"rtlcss": "^4.1.1"
},
"rtlcssConfig": {
"options": {
Expand Down
Loading
Loading